Fix binding loop in AudioResourceControl, and simplify #25955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This finally fixes the long-standing binding loop on the `itemImplicitWidth` binding inside the FlatButton in `titleLoader`. It is still unclear what was precisely the cause; a vague theory might be that asking for `titleLoader.width` inside the FlatButton inside the `titleLoader` might somehow depend on the FlatButton's implicitWidth, which indeed depends on `itemImplicitWidth`, and perhaps StyledTextLabel's `implicitWidth` depends on its `width` because of elision/wrap mode? We'll probably never know, but anyway, it's fixed now.
RomanPudashkin
approved these changes
Jan 7, 2025
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes the long-standing binding loop on the
itemImplicitWidthbinding inside the FlatButton intitleLoader. It is still unclear what was precisely the cause; a vague theory might be that asking fortitleLoader.widthinside the FlatButton inside thetitleLoadermight somehow depend on the FlatButton's implicitWidth, which indeed depends onitemImplicitWidth, and perhaps StyledTextLabel'simplicitWidthdepends on itswidthbecause of elision/wrap mode? We'll probably never know, but anyway, it's fixed now.QA notes: need to check that there are no (visual) regressions in the "Sound" and "Audio FX" rows in the Mixer.