Allow reversal of hook flags within Inspector: Chord #25938
Draft
+88
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't quite work yet, I'm not sure at all why though, hints needed... |
Jojo-Schmitz
commented
Dec 29, 2024
| @@ -2698,6 +2698,8 @@ bool TRead::readProperties(Chord* ch, XmlReader& e, ReadContext& ctx) | |||
| TRead::read(ss, e, ctx); | |||
| ch->add(ss); | |||
| } else if (TRead::readProperty(ch, tag, e, ctx, Pid::STEM_DIRECTION)) { | |||
| } else if (tag == "hookReverse") { | |||
| ch->setHookReversed(e.readBool()); | |||
There was a problem hiding this comment.
Maybe this needs to get added to read302.cpp too, in order to be able to read this from 3.7 scores?
Jojo-Schmitz
force-pushed
the
AllowFlaghookReversal
branch
from
65c8261 to
4ce46eb
Compare
Jojo-Schmitz
changed the title
Jojo-Schmitz
commented
Dec 29, 2024
| @@ -2102,11 +2106,13 @@ PropertyValue Chord::propertyDefault(Pid propertyId) const | |||
| { | |||
| switch (propertyId) { | |||
| case Pid::NO_STEM: return false; | |||
| case Pid::SHOW_STEM_SLASH: return noteType() == NoteType::ACCIACCATURA; | |||
| case Pid::SHOW_STEM_SLASH: return noteType() & NoteType::ACCIACCATURA; | |||
There was a problem hiding this comment.
Unrelated, fixes a Visual Studio warning
Jojo-Schmitz
commented
Dec 29, 2024
| @@ -85,6 +85,7 @@ static constexpr PropertyMetaData propertyList[] = { | |||
| { Pid::DIRECTION, false, "direction", P_TYPE::DIRECTION_V, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "direction") }, | |||
| { Pid::STEM_DIRECTION, false, "StemDirection", P_TYPE::DIRECTION_V, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "stem direction") }, | |||
| { Pid::NO_STEM, false, "noStem", P_TYPE::INT, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "no stem") }, | |||
| { Pid::HOOK_REVERSED, false, "hookReverse", P_TYPE::BOOL, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "reverse hook") }, | |||
There was a problem hiding this comment.
Probably better "hookReversed" or even "reversedHook" (requires changes elsewhere too) and "reversed hook"
Jojo-Schmitz
commented
Dec 29, 2024
| navigationPanel: root.navigationPanel | ||
| navigationRowStart: root.navigationRowStart + 1 | ||
| } | ||
|
|
There was a problem hiding this comment.
doesn't seem to work at all...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of Jojo-Schmitz#742
Resolves: https://musescore.org/en/node/109706
Provides chord (or rather note) inspector checkbox to reverse hooks.
To test:
(Image from MuseScore 3.7)
Kind of a gimmick, but so long as it doesn't hurt anything I suppose it might fulfill little niche use cases for some people.
Testing appreciated