musescore · cbjeukendrup · Dec 1, 2024 · Oct 26, 2024 · Nov 27, 2024 · Nov 29, 2024
diff --git a/buildscripts/cmake/DeclareModuleSetup.cmake b/buildscripts/cmake/DeclareModuleSetup.cmake
@@ -55,6 +55,7 @@ macro(declare_module name)
     unset(MODULE_SRC)
     unset(MODULE_LINK)
     set(MODULE_LINK_GLOBAL ON)
+    set(MODULE_USE_QT ON)
     unset(MODULE_QRC)
     unset(MODULE_BIG_QRC)
     unset(MODULE_UI)
@@ -67,15 +68,23 @@ macro(declare_module name)
     set(MODULE_USE_COVERAGE ON)
 endmacro()
 
+macro(declare_thirdparty_module name)
+    declare_module(${name})
+    set(MODULE_USE_QT OFF)
+    set(MODULE_LINK_GLOBAL OFF)
+    set(MODULE_USE_PCH OFF)
+    set(MODULE_USE_COVERAGE OFF)
+endmacro()
+
 
 macro(add_qml_import_path input_var)
-  if (NOT ${${input_var}} STREQUAL "")
-      set(QML_IMPORT_PATH "$CACHE{QML_IMPORT_PATH}")
-      list(APPEND QML_IMPORT_PATH ${${input_var}})
-      list(REMOVE_DUPLICATES QML_IMPORT_PATH)
-      set(QML_IMPORT_PATH "${QML_IMPORT_PATH}" CACHE STRING
-          "QtCreator extra import paths for QML modules" FORCE)
-  endif()
+    if (NOT ${${input_var}} STREQUAL "")
+        set(QML_IMPORT_PATH "$CACHE{QML_IMPORT_PATH}")
+        list(APPEND QML_IMPORT_PATH ${${input_var}})
+        list(REMOVE_DUPLICATES QML_IMPORT_PATH)
+        set(QML_IMPORT_PATH "${QML_IMPORT_PATH}" CACHE STRING
+            "QtCreator extra import paths for QML modules" FORCE)
+    endif()
 endmacro()
 
 
@@ -87,26 +96,6 @@ macro(setup_module)
         message(STATUS "Configuring ${MODULE} <${MODULE_ALIAS}>")
     endif()
 
-    if (NOT MUSE_FRAMEWORK_PATH)
-        set(MUSE_FRAMEWORK_PATH ${PROJECT_SOURCE_DIR})
-    endif()
-
-    if (MODULE_QRC AND NOT NO_QT_SUPPORT)
-        qt_add_resources(RCC_SOURCES ${MODULE_QRC})
-    endif()
-
-    if (MODULE_BIG_QRC AND NOT NO_QT_SUPPORT)
-        qt_add_big_resources(RCC_BIG_SOURCES ${MODULE_BIG_QRC})
-    endif()
-
-    if (MODULE_UI)
-        find_package(Qt6Widgets)
-        QT6_WRAP_UI(ui_headers ${MODULE_UI} )
-    endif()
-
-    add_qml_import_path(MODULE_QML_IMPORT)
-    add_qml_import_path(MODULE_QMLAPI_IMPORT)
-
     if (CC_IS_EMSCRIPTEN)
         add_library(${MODULE} OBJECT)
     else()
@@ -117,10 +106,36 @@ macro(setup_module)
         add_library(${MODULE_ALIAS} ALIAS ${MODULE})
     endif()
 
+    if (MODULE_USE_QT AND QT_SUPPORT)
+        if (MODULE_QRC AND NOT NO_QT_SUPPORT)
+            qt_add_resources(RCC_SOURCES ${MODULE_QRC})
+        endif()
+
+        if (MODULE_BIG_QRC AND NOT NO_QT_SUPPORT)
+            qt_add_big_resources(RCC_BIG_SOURCES ${MODULE_BIG_QRC})
+        endif()
+    else()
+        set(RCC_SOURCES)
+        set(RCC_BIG_SOURCES)
+
+        set_target_properties(${MODULE} PROPERTIES
+            AUTOMOC OFF
+            AUTOUIC OFF
+            AUTORCC OFF
+        )
+    endif()
+
+    add_qml_import_path(MODULE_QML_IMPORT)
+    add_qml_import_path(MODULE_QMLAPI_IMPORT)
+
     if (BUILD_SHARED_LIBS)
         install(TARGETS ${MODULE} DESTINATION ${SHARED_LIBS_INSTALL_DESTINATION})
     endif()
 
+    if (NOT MUSE_FRAMEWORK_PATH)
+        set(MUSE_FRAMEWORK_PATH ${PROJECT_SOURCE_DIR})
+    endif()
+
     if (MUSE_COMPILE_USE_PCH AND MODULE_USE_PCH)
         if (${MODULE} STREQUAL muse_global)
             target_precompile_headers(${MODULE} PRIVATE ${MUSE_FRAMEWORK_PATH}/buildscripts/pch/pch.h)
@@ -149,7 +164,7 @@ macro(setup_module)
         ${RCC_SOURCES}
         ${RCC_BIG_SOURCES}
         ${MODULE_SRC}
-        )
+    )
 
     target_include_directories(${MODULE} PUBLIC
         ${PROJECT_BINARY_DIR}
@@ -188,11 +203,10 @@ macro(setup_module)
     endif()
 
     if (NOT ${MODULE} MATCHES muse_global AND MODULE_LINK_GLOBAL)
-        set(MODULE_LINK muse_global ${MODULE_LINK})
+        target_link_libraries(${MODULE} PRIVATE muse_global)
     endif()
 
-    set(MODULE_LINK ${CMAKE_DL_LIBS} ${QT_LIBRARIES} ${MODULE_LINK})
-
-    target_link_libraries(${MODULE} PRIVATE ${MODULE_LINK} ${COVERAGE_FLAGS})
-
+    target_link_libraries(${MODULE}
+        PRIVATE ${MODULE_LINK} ${CMAKE_DL_LIBS} ${QT_LIBRARIES} ${COVERAGE_FLAGS}
+    )
 endmacro()
diff --git a/buildscripts/cmake/SetupSndFile.cmake b/buildscripts/cmake/SetupSndFile.cmake
@@ -14,7 +14,7 @@ elseif (OS_IS_WASM)
     set(LIBVORBIS_PATH "" CACHE PATH "Path to libogg sources")
     set(SNDFILE_INCDIR LIBSND_PATH)
 
-    declare_module(sndfile)
+    declare_thirdparty_module(sndfile)
 
     set(MODULE_SRC
         ${LIBSND_PATH}/sndfile.c

diff --git a/buildscripts/packaging/macOS/package.sh b/buildscripts/packaging/macOS/package.sh
@@ -124,7 +124,7 @@ find "${VOLUME}/${LONGER_NAME}.app/Contents/Resources" -name '*.dylib' -exec cod
 # Sign code in other (more conventional) locations
 codesign --force --options runtime --entitlements "${WORKING_DIRECTORY}/../buildscripts/packaging/macOS/entitlements.plist" --deep -s "Developer ID Application: MuseScore" "${VOLUME}/${LONGER_NAME}.app"
 echo "spctl"
-spctl --assess --type execute "${VOLUME}/${LONGER_NAME}.app"
+spctl --assess --type execute -vvv "${VOLUME}/${LONGER_NAME}.app"
 echo "Codesign verify"
 codesign --verify --deep --strict --verbose=2 "${VOLUME}/${LONGER_NAME}.app"
 

diff --git a/src/braille/thirdparty/liblouis/CMakeLists.txt b/src/braille/thirdparty/liblouis/CMakeLists.txt
@@ -1,4 +1,4 @@
-declare_module(liblouis)
+declare_thirdparty_module(liblouis)
 
 add_subdirectory(tables)
 
@@ -36,7 +36,6 @@ set(MODULE_SRC
     ${CMAKE_CURRENT_LIST_DIR}/liblouis/utils.c
 )
 
-set(MODULE_USE_PCH OFF)
 set(MODULE_USE_UNITY OFF)
 set(MODULE_USE_COVERAGE OFF)
 

diff --git a/src/engraving/compat/midi/midipatch.h b/src/engraving/compat/midi/midipatch.h
@@ -32,9 +32,9 @@ namespace mu::engraving {
 
 struct MidiPatch {
     bool drum;
-    String synti;
+    muse::String synti;
     int bank, prog, sfid;
-    String name;
+    muse::String name;
 };
 }
 #endif
diff --git a/src/engraving/dom/actionicon.cpp b/src/engraving/dom/actionicon.cpp
@@ -23,9 +23,6 @@
 #include "actionicon.h"
 
 #include "property.h"
-#include "score.h"
-
-#include "log.h"
 
 using namespace mu;
 using namespace muse::draw;

diff --git a/src/engraving/dom/drumset.h b/src/engraving/dom/drumset.h
@@ -23,7 +23,6 @@
 #ifndef MU_ENGRAVING_DRUMSET_H
 #define MU_ENGRAVING_DRUMSET_H
 
-#include "mscore.h"
 #include "pitchspelling.h"
 #include "../types/types.h"
 

diff --git a/src/engraving/dom/edit.cpp b/src/engraving/dom/edit.cpp
@@ -81,13 +81,13 @@
 #include "system.h"
 #include "systemtext.h"
 #include "tempotext.h"
+#include "text.h"
 #include "textline.h"
 #include "tie.h"
 #include "tiemap.h"
 #include "timesig.h"
-
-#include "tremolotwochord.h"
 #include "tremolosinglechord.h"
+#include "tremolotwochord.h"
 #include "trill.h"
 #include "tuplet.h"
 #include "tupletmap.h"

diff --git a/src/engraving/dom/lyrics.cpp b/src/engraving/dom/lyrics.cpp
@@ -30,6 +30,7 @@
 #include "segment.h"
 #include "staff.h"
 #include "system.h"
+#include "text.h"
 #include "textedit.h"
 #include "undo.h"
 #include "utils.h"

diff --git a/src/engraving/dom/undo.cpp b/src/engraving/dom/undo.cpp
@@ -41,7 +41,6 @@
 #include "bracket.h"
 #include "chord.h"
 #include "clef.h"
-#include "capo.h"
 #include "engravingitem.h"
 #include "excerpt.h"
 #include "fret.h"
@@ -59,12 +58,9 @@
 #include "noteevent.h"
 #include "page.h"
 #include "part.h"
-#include "partialtie.h"
-#include "rest.h"
 #include "score.h"
 #include "segment.h"
 #include "select.h"
-#include "sig.h"
 #include "spanner.h"
 #include "staff.h"
 #include "stafflines.h"
@@ -76,7 +72,6 @@
 #include "textline.h"
 #include "tie.h"
 
-#include "tremolobar.h"
 #include "tuplet.h"
 #include "utils.h"
 

diff --git a/src/engraving/dom/undo.h b/src/engraving/dom/undo.h
@@ -29,9 +29,6 @@
 
 #include <map>
 
-#include "modularity/ioc.h"
-#include "../iengravingfontsprovider.h"
-
 #include "../style/style.h"
 #include "../compat/midi/midipatch.h"
 
@@ -59,12 +56,9 @@
 #include "stafftype.h"
 #include "stringdata.h"
 #include "stringtunings.h"
-#include "synthesizerstate.h"
 #include "soundflag.h"
-#include "text.h"
 
 #include "tremolotwochord.h"
-#include "tremolobar.h"
 
 namespace mu::engraving {
 class Bend;

diff --git a/src/engraving/tests/links_tests.cpp b/src/engraving/tests/links_tests.cpp
@@ -31,9 +31,9 @@
 #include "dom/part.h"
 #include "dom/segment.h"
 #include "dom/tempotext.h"
+#include "dom/text.h"
 #include "dom/undo.h"
 #include "utils/scorerw.h"
-#include "utils/scorecomp.h"
 
 using namespace mu;
 using namespace mu::engraving;

diff --git a/src/framework/audio/internal/platform/osx/osxaudiodriver.mm b/src/framework/audio/internal/platform/osx/osxaudiodriver.mm
@@ -33,7 +33,6 @@
 
 using namespace muse;
 using namespace muse::audio;
-static constexpr char DEFAULT_DEVICE_ID[] = "Systems default";
 
 struct OSXAudioDriver::Data {
     Spec format;

diff --git a/src/framework/audio/thirdparty/flac/CMakeLists.txt b/src/framework/audio/thirdparty/flac/CMakeLists.txt
@@ -1,5 +1,4 @@
-
-declare_module(flac)
+declare_thirdparty_module(flac)
 
 include(GetPlatformInfo)
 include(GetCompilerInfo)
@@ -68,7 +67,6 @@ set (MODULE_SRC
     $<$<BOOL:${OS_IS_WIN}>:${FLAC_SRC}/share/win_utf8_io/win_utf8_io.c>
     )
 
-set(MODULE_USE_PCH OFF)
 set(MODULE_USE_UNITY OFF)
 set(MODULE_USE_COVERAGE OFF)
 

diff --git a/src/framework/audio/thirdparty/fluidsynth/CMakeLists.txt b/src/framework/audio/thirdparty/fluidsynth/CMakeLists.txt
@@ -1,5 +1,4 @@
-
-declare_module(fluidsynth)
+declare_thirdparty_module(fluidsynth)
 
 include(${CMAKE_CURRENT_LIST_DIR}/fluidsynth.cmake)
 
@@ -23,7 +22,6 @@ set(MODULE_LINK
     ${SNDFILE_LIB}
     )
 
-set(MODULE_USE_PCH OFF)
 set(MODULE_USE_UNITY OFF)
 set(MODULE_USE_COVERAGE OFF)
 

diff --git a/src/framework/audio/thirdparty/lame/CMakeLists.txt b/src/framework/audio/thirdparty/lame/CMakeLists.txt
@@ -1,5 +1,4 @@
-
-declare_module(lame)
+declare_thirdparty_module(lame)
 
 include(GetPlatformInfo)
 include(GetCompilerInfo)
@@ -56,7 +55,6 @@ set (MODULE_SRC
     ${SOURCE_LIB}
     )
 
-set(MODULE_USE_PCH OFF)
 set(MODULE_USE_UNITY OFF)
 set(MODULE_USE_COVERAGE OFF)
 

diff --git a/src/framework/audio/thirdparty/opusenc/CMakeLists.txt b/src/framework/audio/thirdparty/opusenc/CMakeLists.txt
@@ -1,5 +1,4 @@
-
-declare_module(opusenc)
+declare_thirdparty_module(opusenc)
 
 include(GetPlatformInfo)
 include(GetCompilerInfo)
@@ -32,7 +31,6 @@ set(MODULE_SRC
 
 set(MODULE_LINK ${OPUS_LIBRARIES})
 
-set(MODULE_USE_PCH OFF)
 set(MODULE_USE_UNITY OFF)
 set(MODULE_USE_COVERAGE OFF)
 

diff --git a/src/framework/audio/thirdparty/opusenc/cmake/SetupOpus.cmake b/src/framework/audio/thirdparty/opusenc/cmake/SetupOpus.cmake
@@ -49,6 +49,12 @@ endif()
 set(OPUS_INCLUDE_DIRS ${OPUS_LIB_DIR}/include)
 set(OPUS_LIBRARIES opus)
 
+set_target_properties(opus PROPERTIES
+    AUTOMOC OFF
+    AUTOUIC OFF
+    AUTORCC OFF
+)
+
 target_no_warning(opus -Wno-conversion)
 target_no_warning(opus -Wno-truncate)
 target_no_warning(opus -Wno-uninitialized)
diff --git a/src/framework/draw/thirdparty/freetype/CMakeLists.txt b/src/framework/draw/thirdparty/freetype/CMakeLists.txt
@@ -18,7 +18,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
-declare_module(freetype)
+declare_thirdparty_module(freetype)
 
 set(FREETYPE_DIR ${CMAKE_CURRENT_LIST_DIR}/freetype-2.13.1)
 set(FREETYPE_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/freetype-2.13.1)
@@ -160,7 +160,6 @@ set(MODULE_DEF
     -DFT2_BUILD_LIBRARY
 )
 
-set(MODULE_USE_PCH OFF)
 set(MODULE_USE_UNITY OFF)
 set(MODULE_USE_COVERAGE OFF)
 

diff --git a/src/framework/uicomponents/view/abstractmenumodel.h b/src/framework/uicomponents/view/abstractmenumodel.h
@@ -19,13 +19,11 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-#ifndef MUSE_UICOMPONENTS_ABSTRACTMENUMODEL_H
-#define MUSE_UICOMPONENTS_ABSTRACTMENUMODEL_H
+#pragma once
 
 #include <QAbstractListModel>
 
 #include "async/asyncable.h"
-#include "ui/uitypes.h"
 #include "menuitem.h"
 
 #include "modularity/ioc.h"
@@ -106,5 +104,3 @@ class AbstractMenuModel : public QAbstractListModel, public muse::Injectable, pu
     MenuItemList m_items;
 };
 }
-
-#endif // MUSE_UICOMPONENTS_ABSTRACTMENUMODEL_H