-
-
Notifications
You must be signed in to change notification settings - Fork 24
⬆️🔒️ Lock file maintenance #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a1abef
to
9d98610
Compare
9d98610
to
93fff0d
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
93fff0d
to
8cd7638
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@burgholzer, I'm a bit confused here... I already replaced the profiles, and the tests pass for me locally. 🤔 |
That is definitely not the only strange thing here.. |
Huh... I'll have a look at this tomorrow! |
I dug a little bit into this and this seems to have to do with something that we did to the If one includes a
This indicates that the config script is looking for |
Okay, a little more info: However, all of that is independent from the error here I suppose. For me, the tests here pass as well. I can check on Thursday on my Linux machine, whether I can reproduce the failures. |
I have now created the profiles in an Ubuntu Docker container. The CI should be green now, but now the tests are failing for me locally, of course. 🙃 |
Now that the The only problem I do see is that the profile tests will fail on macOS systems. I can change the tests to be skipped on non-Linux systems. What do you think, @burgholzer? |
Hm. Previously, these tests were deterministic on all systems if I remember correctly. I don't see an obvious reason why that should have changed. Can we investigate the cause for this so that we better understand if this is expected behavior or whether something is broken here? |
Okay, I think I found the issue. On macOS, the script below prints 5. On Linux (tested using a from qiskit import QuantumCircuit, transpile
import numpy as np
qc = QuantumCircuit(2)
rng = np.random.default_rng(seed=12345)
param = rng.uniform(-np.pi, np.pi)
qc.cp(param, 0, 1)
print(len(transpile(qc, basis_gates=["id", "rz", "sx", "x", "cx"], optimization_level=2, seed_transpiler=12345))) Judging by 973ae0f, this platform dependence of Should I bring this up with the Qiskit devs? 🤔 |
This might actually be a |
I tried around a bit now, and it does seem to be a I have switched to integer parameters now, and the tests are passing on Linux and macOS. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable now. Let's get this in
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.