Backport "Merge PR #6700: CHANGE(server): Extended user stats now requires Ban ACL" to 1.5.x #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Register ACL was required to get extended user statistics (which includes used Mumble version, IP address etc.). However, the Register ACL was deemed to be a rather arbitrary choice for this. Instead, the Ban ACL was chosen as access to information such as packet loss, IP address and used Mumble version and OS seem much more relevant in the case of banning clients than it is for registering them. Also, Ban permission is likely to be a better proxy for whether or not someone is a moderator/admin on a given server than Register privilege. Fixes #6697 (cherry picked from commit 19950b2)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto1.5.x:Questions ?
Please refer to the Backport tool documentation