Backport "Merge PR #6602: FIX(plugins): Unset active positional plugin on unloading it" to 1.5.x #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a plugin is providing positional audio data and it becomes unloaded, such as by disabling the plugin in the settings GUI, the plugin manager may still interact with the plugin through m_activePositionalDataPlugin. This looks unintentional and, in debug mode, this fails an assertion in the plugin fairly quickly: `assertPluginLoaded(this)`. Additionally, in case Mumble shuts down while there exists an active positional data plugin, Mumble will (now) try to log that the plugin has lost link by calling the respective function on the global Log instance. However, at the point where the plugin manager object is destroyed, the log has already been deleted, making this produce a segmentation fault. To prevent this from happening, an explicit check for whether the Log instance still exists has been added to the logging logic. Fixes #6549 (cherry picked from commit e9c53b1)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto1.5.x:Questions ?
Please refer to the Backport tool documentation