Backport "Merge PR #6486: FIX(client): Do not spam log when adjusting volume of clients without certificate" to 1.5.x #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certificate In #5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case. This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users. Fixes #6462 (cherry picked from commit efe91b9)
Krzmbrzl
force-pushed
the
backport/1.5.x/pr-6486
branch
from
f34ee4a to
93508f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto1.5.x:Questions ?
Please refer to the Backport tool documentation