REFAC(client): Implement loadComboBox() that sets the index based on …

…the data

The function that already existed took the index instead of the data,
making it susceptible to errors because the data could be passed instead of the index.

Also, with this new iteration of loadComboBox() we can reorder the items shown to the user as desired.

src/mumble/ConfigWidget.cpp

@@ -69,3 +69,18 @@ void ConfigWidget::loadComboBox(QComboBox *c, int v) {
 		disconnect(SIGNAL(intSignal(int)));
 	}
 }
+
+void ConfigWidget::loadComboBox(QComboBox *c, const QVariant &v) {
+	const int index = c->findData(v);
+	if (index == -1) {
+		return;
+	}
+
+	if (c->currentIndex() != index) {
+		c->setCurrentIndex(index);
+	} else {
+		connect(this, SIGNAL(intSignal(int)), c, SIGNAL(currentIndexChanged(int)));
+		emit intSignal(index);
+		disconnect(SIGNAL(intSignal(int)));
+	}
+}

src/mumble/ConfigWidget.h

@@ -24,6 +24,7 @@ class ConfigWidget : public QWidget {
 	void loadSlider(QSlider *, int);
 	void loadCheckBox(QAbstractButton *, bool);
 	void loadComboBox(QComboBox *, int);
+	void loadComboBox(QComboBox *, const QVariant &);
 signals:
 	void intSignal(int);