voice_local: Fixes and improvements #575
Open
+201
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The talking icon should remain above any actively talking player's head. Even for the local player itself while they are speaking into mic using the voice_ptt bind. This is not currently the case with your PR.. Please keep feature parity, so that means the above, and removing "VOICE: " texts in the bottom of the screen. |
|
Aww I thought voice text in the bottom of the screen was a good idea. Can I leave it in as optional and disabled by default through meta.xml settings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security fixes and enhancements
List: wip
I encourage you to test this resource with at least 1 other player.