Fix getVehicleDummyPosition returning 0,0,0 for the second exhaust#4949
Open
TheCrazy17 wants to merge 1 commit into
Open
Fix getVehicleDummyPosition returning 0,0,0 for the second exhaust#4949TheCrazy17 wants to merge 1 commit into
TheCrazy17 wants to merge 1 commit into
Conversation
…xhaust Most vehicle models have no second exhaust dummy, in which case the game mirrors the primary exhaust on the X axis when placing exhaust and nitro effects (a fallback MTA's dummy hooks replicate). getVehicleDummyPosition returned the raw stored value instead, so "exhaust_second" reported 0, 0, 0 - vehicle centre - while the effects visibly appeared at the mirrored position, e.g. after resetVehicleDummyPositions. Apply the same fallback in the getter so the reported position matches the effective one. Fixes multitheftauto#4761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most vehicle models don't have an
exhaust_seconddummy, so the game places the second exhaust by mirroring the primary exhaust on the X axis. However,getVehicleDummyPosition(veh, "exhaust_second")returned the raw stored value (0, 0, 0- the vehicle centre) instead of the mirrored position where the effects actually appear, e.g. after usingresetVehicleDummyPositions.The getter now applies the same mirroring fallback the game uses, so the reported position always matches the effective one. No visual or behavioural changes - only the returned value is fixed.
Motivation
Fixes #4761
Test plan
Using the script from the issue:
exhaust_secondstill return their real dummy position.Checklist