-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix min_mta_version 'server' not working as expected #3853
Fix min_mta_version 'server' not working as expected #3853
Conversation
Can we just send a warning instead of not letting the resource start since its serversided? (edit: nvm its checked in the same if statement) |
If a dev defines a certain min server version in the meta.xml, their intention is to prevent a server with an inferior server from starting the resource. If the server owner wants to go crazy and execute the resource anyway, then they can easily edit meta.xml to get rid of the min_mta_version setting. |
How does including 2 headers fix this issue? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
thx |
Fixes #3852
Caused by: #3853 (comment)
I found that 2 missing includes were preventing the script from checking if a server's version is too low to start a certain resource that requires a higher version.