Allow client peds to enter/exit client vehicles

[gownosatana]

This pull request allows client created peds to enter client created vehicles.

setPedEnterVehicle(Element ped, [Element vehicle, bool passenger])
When no vehicle is specified ped will enter closest client vehicle

Test resource: test.zip

[FileEX]

Shouldn't we also use the onClientPedVehicleExit / onClientPedVehicleEnter events for peds here?

[gownosatana]

Shouldn't we also use the onClientPedVehicleExit / onClientPedVehicleEnter events for peds here?

yep, it works here too, it's tested

[gownosatana]

All done

[gownosatana]

@tederis review please ✨

[FileEX]

Why do you ask for a review if you don't acknowledge it? You're not following the coding guidelines and you're marking conversations as resolved even though you haven't done anything 🤷

[gownosatana]

Why do you ask for a review if you don't acknowledge it? You're not following the coding guidelines and you're marking conversations as resolved even though you haven't done anything 🤷

I acknowledge you may have reading problems but I made everything you asked for in conversations, just didn't answer to it and pushed commit

[gownosatana]

Also I just want to add you're able to make comments and reviews but you're not one deciding here if pull request should be merged or not, thanks 🙏

[TracerDS]

Why do you ask for a review if you don't acknowledge it? You're not following the coding guidelines and you're marking conversations as resolved even though you haven't done anything 🤷

I acknowledge you may have reading problems but I made everything you asked for in conversations, just didn't answer to it and pushed commit

Actually, you didnt. You pointlessly resolved conversations without adding the requested changes

[gownosatana]

Why do you ask for a review if you don't acknowledge it? You're not following the coding guidelines and you're marking conversations as resolved even though you haven't done anything 🤷

I acknowledge you may have reading problems but I made everything you asked for in conversations, just didn't answer to it and pushed commit

Actually, you didnt. You pointlessly resolved conversations without adding the requested changes

I did in commit e461e70, I'm sorry for your blindness, other changes are approved by fileex.

[FileEX]

This PR already looks good, which unfortunately cannot be said about the others

[TracerDS]

I did in commit e461e70, I'm sorry for your blindness, other changes are approved by fileex.

Being rude to others does not benefit you whatsoever. You only added the type but did not remove the braces; i.e. You acknowledged 1 out of 3 conversations.

[Dutchman101]

@gownosatana Generally speaking, over all your recent PR's and code reviews on it, you are creating a lot of unnecesary drama, and you don't want to agree to do things the way this project has implemented.

You are this close to an organisation (repository) ban and the deletion of all your PR's, so im just warning you to keep yourself in check. Do not reply to this comment. Start showing some more respect, and cut the drama/combativeness.

You're not gonna get things the way you want it; the world or this project doesn't revolve around you. If you don't like that, you are free to just go away.

[Dutchman101]

This PR is being closed for the same reason as the comment explains on the other one closed.