Harden settings dialog activation and error handling #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
settingscommand action fromquery:settingsto a directsettings:dialoginsrc/plugins/settings.rs.LauncherApp::open_settings_dialog()insrc/gui/mod.rsto loadSettingssafely and initializeSettingsEditoronly when the dialog is not already shown, and to surface load errors viaset_error/toasts.self.show_settings = truesites with calls toopen_settings_dialog()so all openings use the guarded flow.src/settings_editor.rsby adding toast/error feedback instead of a plainset_error.Testing
query:settingsusages remain.show_settingsis already true.ToastAPIs so failures will be visible to users at runtime.Codex Task