Suppress autocomplete suggestions when dashboard is visible #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
should_show_dashboardacross suggestion updates and rendering.Description
update_suggestions()to return early if!self.query_autocomplete,self.query.is_empty(), orself.should_show_dashboard(self.query.as_str()).use_dashboard = self.should_show_dashboard(trimmed.as_str())and use it to skip drawing suggestions (self.query_autocomplete && !use_dashboard && !self.suggestions.is_empty()).self.suggestionsand resetself.autocomplete_indexwhen entering the empty-query case and when switching into dashboard mode.src/gui/mod.rsand reuse the existingshould_show_dashboardhelper for consistent behavior.Testing
Codex Task