V1 #1
Open
V1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
requested changes
May 16, 2024
| @@ -0,0 +1,2 @@ | |||
| # http_mptcp | |||
| This | |||
There was a problem hiding this comment.
Nice readme :-)
Should you duplicate what's in the PR message?
| @@ -0,0 +1,2 @@ | |||
| # http_mptcp | |||
| This | |||
There was a problem hiding this comment.
can you remove the binary files from the dist directory? (and add a .gitignore file?)
| class HTTPConnection(http.client.HTTPConnection): | ||
| def __init__(self, host, port=None, timeout=socket._GLOBAL_DEFAULT_TIMEOUT, | ||
| source_address=None, blocksize=8192): | ||
| super().__init__(host, port, timeout, source_address, blocksize) |
There was a problem hiding this comment.
can you not set self._create_connection = _create_connection and that's it, no need to redifine connect, no?
| class HTTPServer(HTTPServer_old): | ||
| def __init__(self, server_address, RequestHandlerClass, bind_and_activate=True): | ||
| """Constructor. May be extended, do not override.""" | ||
| print("bob") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this package aims to be a superset of the native
'http' module in python.
This package should be used in the exact same way,
with the difference that it uses MPTCP. Since using the
package is a conscious choice of the users, no fallback
mechanism is present.
The current implementation is crude and should be treated
more as proof of concept than a finished package.
Attention should be given to the dependencies and functions
inherited from 'http', there is probably a better way of making
things work.