Add ordering for Multihash and MultihashRef #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rklaehn
force-pushed
the
multihash-ord
branch
from
38bc1ec to
4ed454a
Compare
Member
|
@rklaehn Could you please rebase this change? |
This is just lexicographical byte ordering, which should be very fast in case of multihashes since they usually differ within the first 8 byte word. Ordering is useful to have if you e.g. want to output a set of multihashes in a deterministic way for debugging/testing purposes. Also, many possible storage engines work using lexicographical byte ordering.
rklaehn
force-pushed
the
multihash-ord
branch
from
4ed454a to
6946495
Compare
no need for an explicit instance
Collaborator
Author
|
@vmx Done. I also let rust derive the PartialOrd for the MultihashRef, since it is perfectly capable of figuring that out on its own... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just lexicographical byte ordering, which should be very fast
in case of multihashes since they usually differ within the first 8 byte
word.
Ordering is useful to have if you e.g. want to output a set of multihashes
in a deterministic way for debugging/testing purposes. Also, many possible storage engines work using lexicographical byte ordering. And it allows you to use ordering based collections like BTreeSet with multihashes.
This is based on #47 , so should be reviewed once
that is merged.