Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy failing CI. #56

Merged
merged 1 commit into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate_bindings.sh
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ bindgen \
--blocklist-type "Boolean" \
--blocklist-type "dispatch_.*" \
--blocklist-type "(sockaddr|socklen_t|sa_family_t|__darwin_socklen_t|__uint.*_t)" \
--raw-line '#![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal))]' \
--raw-line '#![allow(clippy::unreadable_literal)]' \
--raw-line "use core_foundation_sys::base::{Boolean, CFAllocatorRef, CFTypeID, CFIndex};" \
--raw-line "use core_foundation_sys::string::CFStringRef;" \
--raw-line "use core_foundation_sys::runloop::CFRunLoopRef;" \
Expand Down
6 changes: 3 additions & 3 deletions system-configuration-sys/src/dynamic_store.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* automatically generated by rust-bindgen 0.66.1 */
/* automatically generated by rust-bindgen 0.70.1 */

// Generated using:
// bindgen 0.66.1
// macOS SDK 13.3.
// bindgen 0.70.1
// macOS SDK 14.5.

use core::ffi::c_void;
use core_foundation_sys::array::CFArrayRef;
Expand Down
6 changes: 3 additions & 3 deletions system-configuration-sys/src/dynamic_store_copy_specific.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* automatically generated by rust-bindgen 0.66.1 */
/* automatically generated by rust-bindgen 0.70.1 */

// Generated using:
// bindgen 0.66.1
// macOS SDK 13.3.
// bindgen 0.70.1
// macOS SDK 14.5.

use crate::dynamic_store::SCDynamicStoreRef;
use core_foundation_sys::dictionary::CFDictionaryRef;
Expand Down
6 changes: 3 additions & 3 deletions system-configuration-sys/src/network_configuration.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* automatically generated by rust-bindgen 0.66.1 */
/* automatically generated by rust-bindgen 0.70.1 */

// Generated using:
// bindgen 0.66.1
// macOS SDK 13.3.
// bindgen 0.70.1
// macOS SDK 14.5.

use core::ffi::c_void;
use core_foundation_sys::array::CFArrayRef;
Expand Down
8 changes: 4 additions & 4 deletions system-configuration-sys/src/network_reachability.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* automatically generated by rust-bindgen 0.66.1 */
/* automatically generated by rust-bindgen 0.70.1 */

// Generated using:
// bindgen 0.66.1
// macOS SDK 13.3.
// bindgen 0.70.1
// macOS SDK 14.5.

#![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal))]
#![allow(clippy::unreadable_literal)]
use crate::dispatch_queue_t;
use core_foundation_sys::base::{Boolean, CFAllocatorRef, CFIndex, CFTypeID};
use core_foundation_sys::runloop::CFRunLoopRef;
Expand Down
6 changes: 3 additions & 3 deletions system-configuration-sys/src/preferences.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* automatically generated by rust-bindgen 0.66.1 */
/* automatically generated by rust-bindgen 0.70.1 */

// Generated using:
// bindgen 0.66.1
// macOS SDK 13.3.
// bindgen 0.70.1
// macOS SDK 14.5.

use core::ffi::c_void;
use core_foundation_sys::array::CFArrayRef;
Expand Down
6 changes: 3 additions & 3 deletions system-configuration-sys/src/schema_definitions.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* automatically generated by rust-bindgen 0.66.1 */
/* automatically generated by rust-bindgen 0.70.1 */

// Generated using:
// bindgen 0.66.1
// macOS SDK 13.3.
// bindgen 0.70.1
// macOS SDK 14.5.

use core_foundation_sys::string::CFStringRef;

Expand Down
3 changes: 1 addition & 2 deletions system-configuration/src/network_configuration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,7 @@ mod test {
assert!(service_order.iter().all(|service_id| {
services
.iter()
.find(|service| service.id().as_ref() == Some(&*service_id))
.is_some()
.any(|service| service.id().as_ref() == Some(&*service_id))
}))
}

Expand Down
2 changes: 1 addition & 1 deletion system-configuration/src/network_reachability.rs
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ mod test {

// Can only testify that an empty string is invalid, everything else seems to work
assert!(
!SCNetworkReachability::from_host(&get_cstring("")).is_some(),
SCNetworkReachability::from_host(&get_cstring("")).is_none(),
"Constructed valid SCNetworkReachability from empty string"
);
}
Expand Down