Improve errors in Chart component #3262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
commented
Feb 29, 2024
| @@ -171,12 +171,12 @@ export default function evalJsBindings( | |||
| if (expression) { | |||
| const computed = computationStatuses.get(expression); | |||
| if (computed) { | |||
| if (computed.result) { | |||
| if (!computed.result) { | |||
There was a problem hiding this comment.
The reason why some charts were showing errors before loading was because they were using a cached result here, but using this result didn't let them recognize that the query was still loading.
I changed it to not use the cache if there is an error in the result. There's probably a better solution?
apedroferreira
commented
Feb 29, 2024
| @@ -171,8 +171,8 @@ function Chart({ data = [], loading, error, sx }: ChartProps) { | |||
|
|
|||
| return ( | |||
| <Box sx={{ ...sx, position: 'relative', height: '100%', width: '100%' }} aria-busy={loading}> | |||
| {displayError ? <ErrorOverlay error={displayError} /> : null} | |||
| {loading && !error ? ( | |||
| {displayError && !loading ? <ErrorOverlay error={displayError} /> : null} | |||
There was a problem hiding this comment.
This is just an adjustment, doesn't address any of the reported issues in this PR.
apedroferreira
changed the title
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking a bit into propagating query errors to component binding results, ran into some semi-related issues in charts.
Edit: I moved this back into draft as I thought the fix wouldn't break any tests but it does. This logic is a bit complicated, I wasn't able to find a good solution so far / get to the root of the issue.
Before:
Screen.Recording.2024-02-29.at.18.55.14.mov
After:
Screen.Recording.2024-02-29.at.18.56.18.mov