[core] Harden GitHub Actions permissions #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
oliviertassinari
changed the title
oliviertassinari
added
core
oliviertassinari
force-pushed
the
stepsecurity_remediation_1665004419
branch
from
fe787e6
to
180c7c2
Compare
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
oliviertassinari
force-pushed
the
stepsecurity_remediation_1665004419
branch
from
d8a6abf
to
dd7aaa4
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
stepsecurity_remediation_1665004419
branch
2 times, most recently
from
642267a
to
9a32a3b
Compare
oliviertassinari
force-pushed
the
stepsecurity_remediation_1665004419
branch
from
9a32a3b
to
561043d
Compare
oliviertassinari
approved these changes
Oct 15, 2022
|
I'm merging to unlock it, it has been 10 days. |
This was referenced Oct 15, 2022
| @@ -12,6 +12,9 @@ on: | |||
| jobs: | |||
| noResponse: | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| contents: read | |||
| pull-requests: write | |||
There was a problem hiding this comment.
I think these changes broke the workflow:
- issues with no response aren't closed automatically after 7 days - [pickers] Calendar doesn't circle today's date #6447
- the label is not automatically removed after issue author's response - [data grid] Customize GridColumnsPanel search function #6453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the current configuration of the repositories:
The GitHub actions have a wide range of permission as documented in: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token.
From a security perspective, it's better to limit the access that each action has. For example, https://deps.dev/npm/%40mui%2Fmaterial reports that we could do better:
or this API https://api.securityscorecards.dev/projects/github.com/mui/material-ui
Once merged, we can change the default permissions to be read only.