Skip to content

[scheduler] Store events with processed dates in the state #20145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 7, 2025
Merged

[scheduler] Store events with processed dates in the state #20145

merged 21 commits into from
Nov 7, 2025
+676 −467

Conversation

@flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 30, 2025 •
edited
Loading

Part of #19496

In this PR:

  • Split the CalendarEvent interface in two: SchedulerProcessedEvent and SchedulerEvent
  • Store SchedulerProcessedEvent in the state instead of SchedulerEvent
  • Update all the components and utils the needs to receive a SchedulerProcessedEvent instead of a SchedulerEvent

@flaviendelangle flaviendelangle self-assigned this Oct 30, 2025
@flaviendelangle flaviendelangle added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: scheduler Changes related to the scheduler. labels Oct 30, 2025
@mui-bot
Copy link

mui-bot commented Oct 30, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20145--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a93ebe6

This was referenced Oct 30, 2025
Merged
Merged
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 30, 2025
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 31, 2025
@flaviendelangle flaviendelangle mentioned this pull request Nov 3, 2025
Merged
1 task
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 5, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 6, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 6, 2025
@flaviendelangle flaviendelangle marked this pull request as ready for review November 6, 2025 14:23
rita-codes
rita-codes reviewed Nov 7, 2025
View reviewed changes
packages/x-scheduler/src/month-view/MonthView.test.tsx
it('should place invisible events on the same grid row as the main event', () => {
render(
<EventCalendarProvider events={allDayEventOccurrences} resources={[]}>
<EventCalendarProvider events={allDayEvents} resources={[]}>
Copy link
Member

@rita-codes rita-codes Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

rita-codes
rita-codes reviewed Nov 7, 2025
View reviewed changes
rita-codes
rita-codes approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@rita-codes rita-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!! 🥇

@flaviendelangle flaviendelangle merged commit 6b304bf into mui:master Nov 7, 2025
21 checks passed
@flaviendelangle flaviendelangle deleted the processed-event branch November 7, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rita-codes rita-codes rita-codes approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels

scope: scheduler Changes related to the scheduler. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flaviendelangle @mui-bot @rita-codes