[DataGridPro] Fix selection propagation issue on initialization #15461
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
bug 🐛
|
Deploy preview: https://deploy-preview-15461--material-ui-x.netlify.app/ |
MBilalShafi
changed the title
arminmeh
reviewed
Nov 22, 2024
| @@ -453,9 +453,6 @@ export const useGridRowSelection = ( | |||
| const isFirstRender = React.useRef(true); | |||
| const removeOutdatedSelection = React.useCallback( | |||
| (sortModelUpdated = false) => { | |||
| if (isFirstRender.current) { | |||
There was a problem hiding this comment.
isFirstRender is not used anymore. it can be cleared from the file
with that
how does this affect #14909
since that was the only change added to address that issue
arminmeh
approved these changes
Nov 25, 2024
|
Cherry-pick PRs will be created targeting branches: v7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15382