[docs][CardActionArea] Added demo in docs of cards for adding props to CardActionArea #44789
+140
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR relates to issue: #44730 |
Netlify deploy previewBundle size report |
siddhantantil39
changed the title
zannager
added
docs
|
Hi all, can anyone review the PR please? |
siriwatknp
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks for your contribution! I simplified the demo and docs a bit. I'll wait for @samuelsycamore approval.
|
Thanks for simplifying the code @siriwatknp. Looks much clearer |
Co-authored-by: Sycamore <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
Co-authored-by: Sycamore <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
Co-authored-by: Sycamore <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
Co-authored-by: Sycamore <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
|
@samuelsycamore Upon seeing your review comments, I have committed them. I also understood that the styles make the card look active, it not actually being active. Thanks. |
siddhantantil39
commented
Dec 20, 2024
|
Hi, @siriwatknp are there any more changes needed to be made to the documentation, if so please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44730
This PR consists of a new demo showcasing adding for adding props/attributes to CardActionArea components.
In this onClick behaviour select the clicked card.