[pigment-css] Make @pigment-css/react as peer dependency #44498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
force-pushed
the
fix-pigment-vite-example
branch
from
80ea4f3
to
fe2c623
Compare
mnajdova
reviewed
Nov 21, 2024
This change helps in module resolution across different package
managers, especially pnpm, which expects the imports to be from direct
dependencies.
During sx prop transform, pigment-css plugin adds -
```js
import { sx } from '@pigment-css/react';
```
which would throw an error when using pnpm since @pigment-css/react was
not a direct dependency of the user's application.
brijeshb42
force-pushed
the
fix-pigment-vite-example
branch
from
fe2c623
to
509cdaf
Compare
brijeshb42
changed the title
brijeshb42
added
package: pigment-css
Netlify deploy previewBundle size report |
mnajdova
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps in module resolution across different package
managers, especially pnpm, which expects the imports to be from direct
dependencies.
During sx prop transform, pigment-css plugin adds -
which would throw an error when using pnpm since @pigment-css/react was
not a direct dependency of the user's application.
Note: This is a breaking change.