-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Add ThemeProvider noSsr
to prevent double rendering
#44451
Open
siriwatknp
wants to merge
11
commits into
mui:master
Choose a base branch
from
siriwatknp:feat/theme-provider-force
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
changed the title
[system] Add
[system] Add Nov 18, 2024
disableExtraRender
to prevent extra rerenderingdisableClientRerender
to prevent extra rerendering
…/theme-provider-force
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 18, 2024
…/theme-provider-force
siriwatknp
changed the title
[system] Add
[system] Add Nov 25, 2024
disableClientRerender
to prevent extra rerenderingnoSsr
to prevent double rendering
siriwatknp
changed the title
[system] Add
[system] Add ThemeProvider Nov 25, 2024
noSsr
to prevent double renderingnoSsr
to prevent double rendering
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43263
Context
The current implementation contains rerendering to make the
mode
initiallyundefined
on the client to prevent any hydration mismatch.However, for apps that does not need this double rendering behavior they could not opt-out. This PR introduces a flag to opt-out this behavior.
The use case for this flag are:
undefined
.