Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Mention Toolpad in Example projects section #44391

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Nov 12, 2024

'Example projects' made more sense over Discover more -> 'Related projects' as the placement for Toolpad.
Also linked example folder from Toolpad repo.

Preview: https://deploy-preview-44391--material-ui.netlify.app/material-ui/getting-started/example-projects/

@mui-bot
Copy link

mui-bot commented Nov 12, 2024

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Nov 12, 2024
@prakhargupta1 prakhargupta1 marked this pull request as ready for review November 12, 2024 13:42
@samuelsycamore
Copy link
Contributor

If we add Toolpad here, then this sentence at the top of the doc is no longer technically true:

The following integration examples are available in the /examples folder of the Material UI GitHub repository. [...]

So if we want to proceed, I think we need to rewrite this whole section:

The following integration examples feature Material UI paired with other popular React libraries and frameworks, so you can skip the initial setup steps and jump straight into building.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 17, 2024

On what's the right place for add Toolpad in the docs, it feels like it's the same case as #44315 (comment).

@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Nov 18, 2024

So if we want to proceed, I think we need to rewrite this whole section:

Just did this change, but as per Olivier's PR we may want to put it under Related projects > App starters. I'll let you decide the placement that makes most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation Toolpad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants