-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove unnecessary conditional around .muiName =
#44071
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-44071--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
It could be a use case for mui/pigment-css#84. I have tried to apply this change with https://github.com/mui/material-ui/tree/4bcf32bbb8db43c5fe8c52d300116af00aae40d1/examples/material-ui-pigment-css-vite-ts (and found #44074 along the way), it seems to work fine. A big 💯 to move in this direction. If this code branche is needed, then muiName isn't applied, then it's broken, so in any cases, we can't have this code branch. |
Yep, also found that adding |
I can confirm that it was added during the migration of Pigment CSS, because otherwise it breaks Pigment CSS. @brijeshb42 can likely share more info on why (or @siriwatknp as he was mainly driving the migration). |
It is fine to remove now since we added a fix in the Pigment transform itself. |
Does the fix apply to |
On inspecting the code, I see that we only handle |
There is also |
This was added in #42001. Why?