-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update Taiwan country name in demos #39729
Conversation
Fix Taiwan country name Signed-off-by: Hao <[email protected]>
Fix Taiwan country in CountrySelect.tsx Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Signed-off-by: Hao <[email protected]>
Netlify deploy previewhttps://deploy-preview-39729--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix Taiwan country name.
@@ -88,6 +87,7 @@ The [Data Grid and Data Grid Pro](/x/react-data-grid/) components have their own | |||
| Slovak | sk-SK | `skSK` | | |||
| Spanish | es-ES | `esES` | | |||
| Swedish | sv-SE | `svSE` | | |||
| Taiwan | zh-TW | `zhTW` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chiahao This column should refer to the name of the language though and not the country, so Chinese (Taiwan)
should be accurate?
e.g. https://developers.google.com/admin-sdk/directory/v1/languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry to bother you. Yes, you are right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mj12albert Do I have to revert this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done it ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 👍 @chiahao
This comment was marked as abuse.
This comment was marked as abuse.
To link back the history. We did a change around this in #34611 |
It looks like it's a sensitive topic lukes/ISO-3166-Countries-with-Regional-Codes#43. ChatGTP answer to "What label should a country picker use for Taiwan?" is interesting.
From the historical perspective, https://en.wikipedia.org/wiki/History_of_Taiwan Taiwan seems to make more sense (in the doubt have people living there decide), however, from the perspective of we want to better tailor the library to meet where the Chinese community is at, Taiwan, Province of China would make more sense. No strong preferences, I feel that the previous previous terminology was closer to the reality, so clearer, and more balanced "Taiwan, Republic of China" (a country within a larger country). |
Closes #39728