Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add side nav, dabble in mobile responsiveness #857

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

vladmoroz
Copy link
Contributor

@vladmoroz vladmoroz commented Nov 22, 2024

  • Add side nav (fake routes for now, links 404)
  • Start on mobile responsiveness (no hamburger menu yet, not dialled in spacing yet)
  • Tweak text-sm line height
  • Refine quick nav a11y

https://deploy-preview-857--base-ui.netlify.app/new/components/dialog

@vladmoroz vladmoroz requested a review from colmtuite November 22, 2024 14:27
@vladmoroz vladmoroz added the docs Improvements or additions to the documentation label Nov 22, 2024
@mui-bot
Copy link

mui-bot commented Nov 22, 2024

Netlify deploy preview

https://deploy-preview-857--base-ui.netlify.app/

Generated by 🚫 dangerJS against d819650

@colmtuite
Copy link
Contributor

@vladmoroz Sidebar scroll doesn't bubble up to the window when you reach the top/bottom of the scroll area?

@vladmoroz
Copy link
Contributor Author

@vladmoroz Sidebar scroll doesn't bubble up to the window when you reach the top/bottom of the scroll area?

Do you want it to? I have a slight preference to disable that, but could go either way. Restored scroll chaining in the recent commit, lmk if that feels better.

@colmtuite
Copy link
Contributor

@vladmoroz Feels much better imo. I don't see how it would work the other way, just felt like I couldn't find my way around the website and the website was fighting me.

@vladmoroz vladmoroz merged commit 867f6d7 into mui:master Nov 25, 2024
23 checks passed
@vladmoroz vladmoroz deleted the side-nav branch November 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants