-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Place Quick Nav after the main demo in the DOM #845
base: master
Are you sure you want to change the base?
Conversation
& + * + * { | ||
clear: left; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thinker figure looking at the lobotomised owl
Netlify deploy preview |
@vladmoroz Imo, this won't be expected behaviour when headings become links. |
|
Discussed on a call: Imo, headings should be links in some fashion. I appreciate that it's annoying when the actual heading is clickable, it's nice to be able to select or click headings for no reason at all while you're reading. But we could put a link icon beside each heading, or something similar. Imo, when focus is in the main content pane, it should remain there. Sidebar will/should be considered a separate pane. So focus should either go to sidebar first or last. |
Place Quick Nav after the main demo in the DOM so that keyboard focus follows the reading order
https://deploy-preview-845--base-ui.netlify.app/new/components/dialog