Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog, Popover, Menu, Select, PreviewCard] Unify backdrop implementation #841

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[Dialog, Popover, Menu, Select, PreviewCard] Unify backdrop implementation #841

wants to merge 7 commits into from

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Nov 20, 2024 •
edited
Loading

Unified and simplified backdrop implementation:

  • removed inline styles
  • set role: 'presentation' in all backdrops
  • removed use*Backdrop hooks
  • added an internal backdrop (FloatingOverlay) for modal dialogs and alert dialogs to block pointer interaction
  • added the container prop to DialogBackdrop and AlertDialogBackdrop
  • added the MenuBackdrop

part of #623

@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! component: preview card The React component. labels Nov 20, 2024
@mui-bot
Copy link

mui-bot commented Nov 20, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-841--base-ui.netlify.app/

Generated by 🚫 dangerJS against 97d68fb

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 21, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 21, 2024
atomiks
atomiks reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menu didn't have a Backdrop in the first place, but should?

@michaldudak michaldudak changed the title [Dialog, Menu, Select, PreviewCard] Unify backdrop implementation [Dialog, Popover, Select, PreviewCard] Unify backdrop implementation Nov 22, 2024
@michaldudak michaldudak changed the title [Dialog, Popover, Select, PreviewCard] Unify backdrop implementation [Dialog, Popover, Menu, Select, PreviewCard] Unify backdrop implementation Nov 22, 2024
@michaldudak michaldudak added the component: popover The React component. label Nov 22, 2024
@michaldudak
Copy link
Member Author

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks left review comments

@vladmoroz vladmoroz Awaiting requested review from vladmoroz

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @atomiks