Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collapsible] Make parameters in useCollapsilbe* hooks mandatory #752

Closed
wants to merge 15 commits into from
Closed

[Collapsible] Make parameters in useCollapsilbe* hooks mandatory #752

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3df4e29
add missing defaults to Collapsible* components
sai6855 Oct 22, 2024
292b2d0
Merge branch 'master' into collapsible-defaults
sai6855 Nov 30, 2024
e5410ce
make parmas in required
sai6855 Nov 30, 2024
91d1149
pnpm prettier
sai6855 Nov 30, 2024
afeadeb
fix accordion item
sai6855 Nov 30, 2024
84aaecb
fix accordion item types
sai6855 Nov 30, 2024
d65b674
fix accordion panel props
sai6855 Nov 30, 2024
6e47ab1
make types partial
sai6855 Nov 30, 2024
24b9ccd
fix collapslble trigger
sai6855 Nov 30, 2024
082cb09
fix root types
sai6855 Dec 2, 2024
366befc
fix acc item
sai6855 Dec 2, 2024
812dffe
docs:api
sai6855 Dec 2, 2024
bcdebd1
prettier
sai6855 Dec 2, 2024
d28ad11
Merge branch 'master' into collapsible-defaults
sai6855 Dec 2, 2024
1482bbc
fix acc item
sai6855 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mui-base/src/Collapsible/Content/CollapsibleContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const CollapsibleContent = React.forwardRef(function CollapsibleContent(
props: CollapsibleContent.Props,
forwardedRef: React.ForwardedRef<HTMLButtonElement>,
) {
const { className, htmlHidden, render, ...otherProps } = props;
const { className, htmlHidden = 'hidden', render, ...otherProps } = props;

const { animated, mounted, open, contentId, setContentId, setMounted, setOpen, ownerState } =
useCollapsibleContext();
Expand Down
6 changes: 3 additions & 3 deletions packages/mui-base/src/Collapsible/Root/CollapsibleRoot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ const CollapsibleRoot = React.forwardRef(function CollapsibleRoot(
forwardedRef: React.ForwardedRef<HTMLDivElement>,
) {
const {
animated,
animated = true,
Copy link
Contributor Author

@sai6855 sai6855 Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added deafult props in component,to make it consistent with other components.

base-ui/packages/mui-base/src/Dialog/Root/DialogRoot.tsx

Line 25 in d2e58dd

animated = true,

base-ui/packages/mui-base/src/Menu/Root/MenuRoot.tsx

Line 20 in d2e58dd

animated = true,

children,
className,
defaultOpen,
disabled,
defaultOpen = true,
disabled = false,
onOpenChange,
open,
render: renderProp,
Expand Down
Loading