[docs] Use the new logo #750

vladmoroz · 2024-10-21T14:05:57Z

New logo and favicons
Tweaked homepage

mui-bot · 2024-10-21T14:09:10Z

Netlify deploy preview

https://deploy-preview-750--base-ui.netlify.app/

Generated by 🚫 dangerJS against 3067288

vladmoroz · 2024-10-22T08:01:58Z

docs/src/styles.css

+:root {
+  --color-content: #fff;
+  --color-background: oklch(98% 0.25% 264);
+  --color-foreground: oklch(21% 2% 264);
+  --color-selection: oklch(80% 0.2 264 / 60%);
+  --color-gray: oklch(12.7% 6% 264 / 67%);
+  --color-link: oklch(47% 50% 264);
+  --color-border: oklch(20% 12% 264 / 25%);
+  --color-gridline: oklch(91.6% 1% 264);
+
+  @media (prefers-color-scheme: dark) {
+    --color-content: #000;
+    --color-background: #000;
+    --color-foreground: oklch(90% 2% 264);
+    --color-selection: oklch(50% 0.2 264 / 80%);
+    --color-gray: oklch(90% 6% 264 / 70%);
+    --color-link: oklch(69% 50% 264);
+    --color-border: oklch(90% 12% 264 / 35%);
+    --color-gridline: oklch(24% 1% 264);
+  }
+}


The functional colours are provisional, it's likely I'll end up doing a normal Radix-style palette once there is a bit more interactive UI to work with

michaldudak · 2024-10-22T13:12:36Z

.eslintrc.js

@@ -38,6 +38,9 @@ module.exports = {
      },
    ],
    '@typescript-eslint/no-redeclare': 'off',
+
+    // We LOVE non-breaking spaces here
+    'no-irregular-whitespace': 'off',


Wouldn't setting { skipJSXText: true, skipStrings: true } be enough?

michaldudak · 2024-10-22T13:14:25Z

docs/src/app/(new)/page.tsx

+            {description}
+          </h1>
+          <p className="text-color-gray mb-4 text-pretty 2xl:text-lg">
+            From the creators of Radix, Floating UI, and MUI.


Suggested change

From the creators of Radix, Floating UI, and MUI.

From the creators of Radix, Floating UI, and Material UI.

@colmtuite thoughts?

@vladmoroz It will be MUI next year, but yeah it should be "Material UI" for now.

@vladmoroz It will be MUI next year, but yeah it should be "Material UI" for now.

Looks like I also don't understand the difference between MUI and Material UI 🫠
How come it will change next year? Material UI library will be renamed to MUI?

Current state:
MUI - the company
Material UI - the library

Who knows what the future will bring ;)

michaldudak · 2024-10-22T13:15:23Z

docs/src/app/layout.tsx

 import { Metadata } from 'next';
-import { GoogleAnalytics } from 'docs/src/components/GoogleAnalytics';
+import * as React from 'react';


We have a convention to import React first.

Can I add an ES lint rule to do import order so that it's fixed automatically then? I agree with the convention, I did similar for Radix Themes with a couple other ordering rules in the mix, just don't think a human should waste time doing it manually

sure!
I vaguely recall we had one in Material UI, so I don't know why it doesn't work her (but perhaps I'm hallucinating)

michaldudak · 2024-10-22T13:17:09Z

docs/src/components/Logo.css

@@ -0,0 +1,19 @@
+@layer components {


So what's wrong with CSS modules after all? Are we going to have plain CSS, CSS modules, and Tailwind at the same time, or do you want to get rid of modules completely?

My personal preference would be just plain CSS + Tailwind, and get rid of the current CSS Modules usage as the docs are built out.

I would have went for CSS Modules in a larger team with developers of varying skill levels, but here I don't think there's any significant problem that the tech solves for us. (I always prefix classes with component name so clashes won't happen with basic hygiene).

Do you feel OK about this or would you strongly want to use CSS Modules anyway?

I would use CSS modules and not go with Tailwind at all, but it's more of a preference than an objective advantage of one tech over the other. Since you'll mostly work on the docs, it's your call.

michaldudak · 2024-10-22T13:21:12Z

Side note: could you prefix your PR titles with the main tag ([docs] in this case)? It's a convention we use across our repos (and it makes it easier to write the changelog).

vladmoroz · 2024-10-22T16:23:25Z

Side note: could you prefix your PR titles with the main tag ([docs] in this case)? It's a convention we use across our repos (and it makes it easier to write the changelog).

Sure!

atomiks

New homepage looks super nice 👍

vladmoroz added the docs Improvements or additions to the documentation label Oct 21, 2024

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 21, 2024

Update homepage, logos, and favicons

d94fade

vladmoroz force-pushed the homepage branch from 44ddcf8 to d94fade Compare October 21, 2024 22:06

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 21, 2024

vladmoroz marked this pull request as ready for review October 21, 2024 22:08

vladmoroz requested review from atomiks and michaldudak as code owners October 21, 2024 22:08

vladmoroz requested a review from colmtuite October 22, 2024 07:41

vladmoroz changed the title ~~Use new logo~~ Use the new logo Oct 22, 2024

vladmoroz added 4 commits October 22, 2024 09:45

Empty commit

534a365

Tweak meta

18023df

Undo unnecessary change

25260d8

typo

ad1d5e5

vladmoroz commented Oct 22, 2024

View reviewed changes

vladmoroz added 4 commits October 22, 2024 11:03

Logo tweaks

67512c8

Logo tweaks

276e658

Logo pattern

09df826

Dial in the layout and add a CSS file for Colm

6a88502

michaldudak reviewed Oct 22, 2024

View reviewed changes

Big type

3067288

vladmoroz changed the title ~~Use the new logo~~ [docs] Use the new logo Oct 22, 2024

vladmoroz marked this pull request as draft October 23, 2024 17:45

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 23, 2024

atomiks reviewed Oct 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Use the new logo #750

[docs] Use the new logo #750

vladmoroz commented Oct 21, 2024 •

edited

Loading

mui-bot commented Oct 21, 2024 •

edited

Loading

vladmoroz Oct 22, 2024 •

edited

Loading

michaldudak Oct 22, 2024

michaldudak Oct 22, 2024

vladmoroz Oct 22, 2024

colmtuite Oct 23, 2024

vladmoroz Oct 24, 2024

michaldudak Oct 25, 2024

michaldudak Oct 22, 2024

vladmoroz Oct 22, 2024

michaldudak Oct 25, 2024 •

edited

Loading

michaldudak Oct 22, 2024

vladmoroz Oct 23, 2024

michaldudak Oct 24, 2024

michaldudak commented Oct 22, 2024

vladmoroz commented Oct 22, 2024

atomiks left a comment

	From the creators of Radix, Floating UI, and MUI.
	From the creators of Radix, Floating UI, and Material UI.

[docs] Use the new logo #750

Are you sure you want to change the base?

[docs] Use the new logo #750

Conversation

vladmoroz commented Oct 21, 2024 • edited Loading

mui-bot commented Oct 21, 2024 • edited Loading

Netlify deploy preview

vladmoroz Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaldudak Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaldudak commented Oct 22, 2024

vladmoroz commented Oct 22, 2024

atomiks left a comment

Choose a reason for hiding this comment

vladmoroz commented Oct 21, 2024 •

edited

Loading

mui-bot commented Oct 21, 2024 •

edited

Loading

vladmoroz Oct 22, 2024 •

edited

Loading

michaldudak Oct 25, 2024 •

edited

Loading