[field] Prevent defaultValue reset on focus for uncontrolled inputs #2543
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingokpp
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
reviewed
Aug 20, 2025
Comment on lines
119
to
121
| if (value != null) { | ||
| if (isControlled) { |
There was a problem hiding this comment.
Do the tests still pass without changing this? The useControlled hook should fire onValueChange for both defaultValue and value when it gets changed (not via ref mutation though of course)
const [value, setValueUnwrapped] = useControlled({
controlled: valueProp,
default: defaultValue,
name: 'FieldControl',
state: 'value',
});
atomiks
approved these changes
Aug 20, 2025
LukasTy
added
type: bug
LukasTy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2530
Problem:
Inputs wrapped in Field.Root were incorrectly resetting to their defaultValue when focused after being programmatically changed via ref (e.g., inputRef.current.value = ""). This behavior differed from plain HTML inputs and unwrapped Input components.
Cause:
The FieldControl component was always passing a value prop to the input element, making React treat it as controlled even when only defaultValue was provided. When the DOM value was changed directly, React's internal state wasn't updated, causing re-renders to reset the input.
My Solution:
Modified FieldControl to conditionally pass either value (for controlled) or defaultValue (for uncontrolled) props to the input element, matching standard behavior.
Note: Before implementing the fix, I created some failing tests that reproduced the behaviour mentioned in the issue.