-
-
Notifications
You must be signed in to change notification settings - Fork 218
[popups] initialFocus
and finalFocus
functions
#2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atomiks
wants to merge
6
commits into
mui:master
Choose a base branch
from
atomiks:feat/focus-fns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atomiks <[email protected]>
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mnajdova
reviewed
Aug 20, 2025
packages/react/src/floating-ui-react/components/FloatingFocusManager.tsx
Outdated
Show resolved
Hide resolved
17ba3e4
to
5cc951c
Compare
5cc951c
to
cdc7894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Introduces changes that are not backward compatible.
scope: alert dialog
This is the name of the generic UI component, not the React module!
scope: dialog
This is the name of the generic UI component, not the React module!
scope: menu
This is the name of the generic UI component, not the React module!
scope: popover
This is the name of the generic UI component, not the React module!
type: new feature
Expand the scope of the product to solve a new problem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vladmoroz this should solve your concerns with managing focus.
Breaking: if you specify a function, return the element directly instead of a ref