Skip to content

[core] Import @floating-ui/react #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented May 30, 2025

Changes:

  • Import @floating-ui/react codebase at ./src/floating-ui-react
  • Add its dependencies here
  • Renamed ./src/utils/floating-ui to ./src/utils/interactions (plan to move interaction hooks here in a later PR)
  • Merge duplicate hooks (useClick, useEventCallback, useId, etc)
  • Merge duplicate components (FocusGuard)
  • Small perf touchup on mergeProps (I really could not resist)

@romgrk romgrk added core Infrastructure work going behind the scene enhancement This is not a bug, nor a new feature performance labels May 30, 2025
@mui-bot
Copy link

mui-bot commented May 30, 2025

Bundle size report

Total Size Change:${\tiny{\color{green}▼}}$-30.7KB(-2.12%) - Total Gzip Change:${\tiny{\color{green}▼}}$-5.63KB(-1.15%)
Files: 41 total (0 added, 0 removed, 38 changed)

@base-ui-components/reactparsed:${\tiny{\color{green}▼}}$-5.58KB(-1.83%) gzip:${\tiny{\color{green}▼}}$-1.29KB(-1.40%)
@base-ui-components/react/context-menuparsed:${\tiny{\color{green}▼}}$-3.81KB(-3.38%) gzip:${\tiny{\color{green}▼}}$-271B(-0.73%)
@base-ui-components/react/menuparsed:${\tiny{\color{green}▼}}$-3.81KB(-3.34%) gzip:${\tiny{\color{green}▼}}$-833B(-2.20%)
@base-ui-components/react/popoverparsed:${\tiny{\color{green}▼}}$-3.28KB(-3.81%) gzip:${\tiny{\color{green}▼}}$-432B(-1.49%)
@base-ui-components/react/selectparsed:${\tiny{\color{green}▼}}$-2.92KB(-2.63%) gzip:${\tiny{\color{green}▼}}$-183B(-0.49%)
@base-ui-components/react/navigation-menuparsed:${\tiny{\color{green}▼}}$-2.4KB(-2.83%) gzip:${\tiny{\color{green}▼}}$-497B(-1.75%)
@base-ui-components/react/dialogparsed:${\tiny{\color{green}▼}}$-2.4KB(-4.57%) gzip:${\tiny{\color{green}▼}}$-589B(-3.34%)
@base-ui-components/react/alert-dialogparsed:${\tiny{\color{green}▼}}$-2.4KB(-4.60%) gzip:${\tiny{\color{green}▼}}$-530B(-3.03%)
@base-ui-components/react/preview-cardparsed:${\tiny{\color{green}▼}}$-2.03KB(-3.42%) gzip:${\tiny{\color{green}▼}}$-310B(-1.54%)
@base-ui-components/react/tooltipparsed:${\tiny{\color{green}▼}}$-1.63KB(-2.55%) gzip:${\tiny{\color{green}▼}}$-247B(-1.14%)

Show 28 more bundle changes

@base-ui-components/react/number-fieldparsed:${\tiny{\color{red}▲}}$+276B(+0.96%) gzip:${\tiny{\color{red}▲}}$+76B(+0.73%)
@base-ui-components/react/utilsparsed:${\tiny{\color{red}▲}}$+258B(+3.16%) gzip:${\tiny{\color{red}▲}}$+82B(+2.60%)
@base-ui-components/react/toastparsed:${\tiny{\color{red}▲}}$+199B(+0.75%) gzip:${\tiny{\color{red}▲}}$+21B(+0.22%)
@base-ui-components/react/menubarparsed:${\tiny{\color{red}▲}}$+80B(+0.41%) gzip:${\tiny{\color{green}▼}}$-21B(-0.29%)
@base-ui-components/react/unstable-no-ssrparsed:${\tiny{\color{green}▼}}$-630B(-49.65%) gzip:${\tiny{\color{green}▼}}$-284B(-41.70%)
@base-ui-components/react/sliderparsed:${\tiny{\color{green}▼}}$-82B(-0.33%) gzip:${\tiny{\color{green}▼}}$-37B(-0.40%)
@base-ui-components/react/radio-groupparsed:${\tiny{\color{green}▼}}$-55B(-0.27%) gzip:${\tiny{\color{green}▼}}$-33B(-0.43%)
@base-ui-components/react/toggleparsed:${\tiny{\color{green}▼}}$-46B(-0.51%) gzip:${\tiny{\color{green}▼}}$-18B(-0.49%)
@base-ui-components/react/avatarparsed:${\tiny{\color{green}▼}}$-38B(-0.53%) gzip:${\tiny{\color{green}▼}}$-13B(-0.45%)
@base-ui-components/react/radioparsed:${\tiny{\color{green}▼}}$-32B(-0.21%) gzip:${\tiny{\color{green}▼}}$-14B(-0.25%)
@base-ui-components/react/toolbarparsed:${\tiny{\color{green}▼}}$-32B(-0.16%) gzip:${\tiny{\color{green}▼}}$-25B(-0.37%)
@base-ui-components/react/checkboxparsed:${\tiny{\color{green}▼}}$-26B(-0.14%) gzip:${\tiny{\color{green}▼}}$-9B(-0.13%)
@base-ui-components/react/checkbox-groupparsed:${\tiny{\color{green}▼}}$-26B(-0.21%) gzip:${\tiny{\color{green}▼}}$-14B(-0.29%)
@base-ui-components/react/fieldparsed:${\tiny{\color{green}▼}}$-26B(-0.19%) gzip:${\tiny{\color{green}▼}}$-11B(-0.21%)
Base UI checkboxparsed:${\tiny{\color{green}▼}}$-26B(-0.14%) gzip:${\tiny{\color{green}▼}}$-5B(-0.07%)
@base-ui-components/react/accordionparsed:${\tiny{\color{green}▼}}$-25B(-0.11%) gzip:${\tiny{\color{green}▼}}$-7B(-0.09%)
@base-ui-components/react/inputparsed:${\tiny{\color{green}▼}}$-23B(-0.21%) gzip:${\tiny{\color{green}▼}}$-11B(-0.25%)
@base-ui-components/react/fieldsetparsed:${\tiny{\color{green}▼}}$-22B(-0.37%) gzip:${\tiny{\color{green}▼}}$-9B(-0.36%)
@base-ui-components/react/meterparsed:${\tiny{\color{green}▼}}$-22B(-0.30%) gzip:${\tiny{\color{green}▼}}$-15B(-0.49%)
@base-ui-components/react/progressparsed:${\tiny{\color{green}▼}}$-22B(-0.29%) gzip:${\tiny{\color{green}▼}}$-15B(-0.49%)
@base-ui-components/react/collapsibleparsed:${\tiny{\color{green}▼}}$-20B(-0.11%) gzip:${\tiny{\color{green}▼}}$-6B(-0.10%)
@base-ui-components/react/switchparsed:${\tiny{\color{green}▼}}$-20B(-0.14%) gzip:${\tiny{\color{green}▼}}$-12B(-0.22%)
@base-ui-components/react/toggle-groupparsed:${\tiny{\color{green}▼}}$-19B(-0.14%) gzip:${\tiny{\color{green}▼}}$-28B(-0.52%)
@base-ui-components/react/scroll-areaparsed:${\tiny{\color{green}▼}}$-13B(-0.08%) gzip:${\tiny{\color{green}▼}}$-9B(-0.16%)
@base-ui-components/react/tabsparsed:${\tiny{\color{green}▼}}$-13B(-0.05%) gzip:${\tiny{\color{green}▼}}$-33B(-0.38%)
@base-ui-components/react/formparsed:${\tiny{\color{green}▼}}$-1B(-0.02%) gzip:${\tiny{\color{red}▲}}$+1B(+0.04%)
@base-ui-components/react/separatorparsed:${\tiny{\color{green}▼}}$-1B(-0.02%) gzip:${\tiny{\color{green}▼}}$-1B(-0.05%)
@base-ui-components/react/use-renderparsed:${\tiny{\color{green}▼}}$-1B(-0.03%) gzip:${\tiny{\color{green}▼}}$-1B(-0.06%)

Details of bundle changes

Generated by 🚫 dangerJS against 59be3cb

Copy link

pkg-pr-new bot commented May 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@2002

commit: 59be3cb

@romgrk romgrk marked this pull request as ready for review May 30, 2025 05:22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is NextFloatingDelayGroup.

@atomiks
Copy link
Contributor

atomiks commented Jun 1, 2025

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going behind the scene enhancement This is not a bug, nor a new feature performance PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants