[core] Refactor: "style hooks" to "state attributes" #1940
+319
−318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
core
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
github-actions
bot
added
the
PR: out-of-date
|
@colmtuite, are you OK with changing this term? |
|
@michaldudak @romgrk Sure |
|
@romgrk are you going to update this PR? I can take it over if you'd like. |
|
I'm working on the new virtualization engine for the time being, so you can take over this PR if you want it merged. |
github-actions
bot
removed
the
PR: out-of-date
Bundle size report
|
michaldudak
force-pushed
the
refactor-style-hooks
branch
from
39c881c to
ed23ec3
Compare
michaldudak
added
internal
and removed
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the "style hooks" terminology which is unclear.
Now that I read the PR, I feel like it could be simply
stateMappinginstead ofstateAttributesMapping. The "attributes" token would be missing, but it would be less verbose and "state mapping" is clear enough as a concept, imo. Opinions welcome, I could go with either.