Skip to content

[scroll area] Ignore data-scrolling during programmatic scroll #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[scroll area] Ignore data-scrolling during programmatic scroll #1908

wants to merge 3 commits into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented May 13, 2025

Closes #983

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 13, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@1908

commit: 844d205

@netlify Netlify
Copy link

netlify bot commented May 13, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 844d205
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6835b243f1503b0008ea0a63
😎 Deploy Preview https://deploy-preview-1908--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review May 13, 2025 22:23
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2025
@atomiks atomiks force-pushed the fix/scroll-area-user-interaction branch from 7dfd88f to 844d205 Compare May 27, 2025 12:38
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 27, 2025
mj12albert
mj12albert approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ~ though testing on master it seems to still work? When loading /react/components/tooltip the scrollbars aren't visible when the sidenav autoscrolls to the bottom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert mj12albert approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees
No one assigned
Labels
component: scroll area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scroll area] Ignore state changes during programmatic scroll
2 participants
@atomiks @mj12albert