Added logs while importing course #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaisdar001
reviewed
Feb 1, 2022
cms/djangoapps/contentstore/tasks.py
Outdated
| @@ -526,9 +526,11 @@ def get_dir_for_filename(directory, filename): | |||
| return | |||
|
|
|||
| if not user_has_access(user): | |||
| logging.info(f'Course import {course_key_string}: User is not allowed to import') | |||
awaisdar001
reviewed
Feb 1, 2022
cms/djangoapps/contentstore/tasks.py
Outdated
| return | ||
|
|
||
| if not file_is_supported(): | ||
| logging.info(f'Course import {course_key_string}: File not supported') |
awaisdar001
reviewed
Feb 1, 2022
cms/djangoapps/contentstore/tasks.py
Outdated
| @@ -737,14 +739,18 @@ def validate_course_olx(courselike_key, course_dir, status): | |||
| if not course_import_olx_validation_is_enabled(): | |||
| return olx_is_valid | |||
| try: | |||
| if str(courselike_key) == "course-v1:ArbiX+CS101+2014_T3": | |||
| logging.info(log_prefix + "Validating. Calling olxcleaner.validate") | |||
There was a problem hiding this comment.
This is the default prefix they are using in every log of this function. This string is equal to f"Course import {courselike_key}"
awaisdar001
reviewed
Feb 1, 2022
cms/djangoapps/contentstore/tasks.py
Outdated
| if str(courselike_key) == "course-v1:ArbiX+CS101+2014_T3": | ||
| logging.info(log_prefix + "Course validated. No errors") | ||
| except Exception as e: # pylint: disable=broad-except | ||
| LOGGER.exception(f'{log_prefix}: CourseOlx could not be validated' + str(e)) |
There was a problem hiding this comment.
LOGGER.exception automatically prints the stack trace so I don't think `str(e) is needed here.
awaisdar001
reviewed
Feb 1, 2022
common/djangoapps/util/monitoring.py
Outdated
| @@ -13,9 +13,11 @@ def monitor_import_failure(course_key, import_step, message=None, exception=None | |||
| """ | |||
| set_custom_attribute('course_import_failure', import_step) | |||
| set_custom_attributes_for_course_key(course_key) | |||
| logging.info(f"Course import failed at step {import_step} for course with key {course_key}") | |||
There was a problem hiding this comment.
shouldn't these also be behind the course key condition?
added 2 commits
February 1, 2022 15:42
…/xmodule/xmodule/modulestore in files xml.py and xml_importer.py
saadyousafarbi
suggested changes
Feb 1, 2022
| @@ -743,7 +743,7 @@ def validate_course_olx(courselike_key, course_dir, status): | |||
| ignore=settings.COURSE_OLX_VALIDATION_IGNORE_LIST, | |||
| allowed_xblocks=ALL_ALLOWED_XBLOCKS | |||
| ) | |||
| except Exception: # pylint: disable=broad-except | |||
| except Exception as e: # pylint: disable=broad-except | |||
There was a problem hiding this comment.
I added "as e" after Exception to print it. Awais bhai told me LOGGER.Exception prints exception. Restored old code.
awaisdar001
reviewed
Feb 1, 2022
Comment on lines
384
to
385
| if str(target_course_id) == "course-v1:ArbiX+CS101+2014_T3": | ||
| logging.info(f"Investigation Log: {target_course_id} : Course Descriptor is None") |
There was a problem hiding this comment.
this shouldn't be part of the if course_descriptor is None: block. the logs should be immediately after the finally: block.
logging.info(f"Investigation Log: {target_course_id} : {course_descriptor} ") something like this.
awaisdar001
reviewed
Feb 1, 2022
| @@ -522,6 +525,8 @@ def get_policy(usage_id): | |||
| course_descriptor = system.process_xml(etree.tostring(course_data, encoding='unicode')) | |||
| # If we fail to load the course, then skip the rest of the loading steps | |||
| if isinstance(course_descriptor, ErrorBlock): | |||
| if str(target_course_id) == "course-v1:ArbiX+CS101+2014_T3": | |||
| logging.info(f"Investigation Log: {target_course_id} : Course Descriptor is instance of ErrorBlock") | |||
There was a problem hiding this comment.
I see single quotes here in this file, please use single quotes here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logs near course validation in course import.