Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tokenization endpoint #3710

Merged
merged 3 commits into from
Oct 2, 2024
Merged

feat: tokenization endpoint #3710

merged 3 commits into from
Oct 2, 2024

Conversation

shraddhazpy
Copy link
Contributor

@shraddhazpy shraddhazpy commented Oct 1, 2024

Description

This PR is a step towards #1649

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit fa0f048
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66fcce2255dd240008decfac
😎 Deploy Preview https://deploy-preview-3710--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shraddhazpy
Copy link
Contributor Author

@mudler Guessing that this would need work on the cpp side as well to get the tokenization going there too.

@mudler
Copy link
Owner

mudler commented Oct 1, 2024

@mudler Guessing that this would need work on the cpp side as well to get the tokenization going there too.

Correct, we basically need to expose

std::vector<llama_token> tokenize(const json & json_prompt, bool add_bos) const
as a gRPC method, but it would make sense also to do it afterwards 👍 - thanks for the PR!

@mudler
Copy link
Owner

mudler commented Oct 1, 2024

@shraddhazpy I need the commits signed off (you can do that with git rebase origin/master --signoff) in order to merge the PR

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@shraddhazpy shraddhazpy marked this pull request as ready for review October 2, 2024 02:33
@mudler mudler merged commit 5488fc3 into mudler:master Oct 2, 2024
29 checks passed
@mudler mudler added the enhancement New feature or request label Oct 2, 2024
@mudler mudler mentioned this pull request Oct 2, 2024
1 task
@shraddhazpy shraddhazpy deleted the tokenization branch October 2, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants