Slight for loop gas optimization #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use unchecked and pre-increment for for-loop iterators
mudgen
reviewed
Sep 17, 2023
| @@ -102,7 +103,8 @@ library LibDiamond { | |||
| address oldFacetAddress = ds.selectorToFacetAndPosition[selector].facetAddress; | |||
| require(oldFacetAddress == address(0), "LibDiamondCut: Can't add function that already exists"); | |||
| addFunction(ds, selector, selectorPosition, _facetAddress); | |||
| selectorPosition++; | |||
| ++selectorPosition; | |||
| unchecked { ++selectorIndex; } | |||
There was a problem hiding this comment.
for (uint256 selectorIndex; selectorIndex < _functionSelectors.length; selectorIndex++)
selectorPosition is now being incremented twice in each iteration of the loop, instead of once.
|
@redsh4de I appreciate this. I found one bug in the pull request. Please fix and I can merge. Thanks for your help. |
… for loop Remove selectorIndex++ from the for loop, as incrementing is being done in an unchecked block already
|
That should take care of it! @mudgen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ihas a maximum limit set by the loop, there are no downsides for this approach