Merge pull request #2 from muak/FixEntryCell

Fix iOS EntryCell
muak · Nov 15, 2017 · 71ddd3d · 71ddd3d
2 parents ba6864f + 5bcd52b
commit 71ddd3d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/SettingsView.iOS/Cells/EntryCellRenderer.cs b/SettingsView.iOS/Cells/EntryCellRenderer.cs
@@ -125,7 +125,11 @@ protected override void Dispose(bool disposing)
 
         void UpdateValueText()
         {
-            ValueField.Text = _EntryCell.ValueText;
+            //Without this judging, TextField don't correctly work when inputting Japanese (maybe other 2byte languages either).
+            if (ValueField.Text != _EntryCell.ValueText)
+            {
+                ValueField.Text = _EntryCell.ValueText;
+            }
         }
 
         void UpdateValueTextFontSize()

diff --git a/nuget/SettingsView_mac.nuspec b/nuget/SettingsView_mac.nuspec
@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
     <metadata>
         <id>AiForms.SettingsView</id>
-        <version>0.0.1-pre5</version>
+        <version>0.0.1-pre6</version>
         <title>SettingsView for Xamarin.Forms</title>
         <authors>kamu</authors>
         <owners>kamu</owners>
@@ -16,8 +16,9 @@ There are various cells such as (LabelCell,ButtonCell,CommandCell,SwitchCell,Che
         <releaseNotes>
 ## Bug fix
 
-* Crashed when used style
-* When constituted TabbedPage/NavigationPage/ContentPage, didn't move collectlly.
+* EntryCell didn't correctly work when inputting Japanese. (pre6)
+* Crashed when used style.
+* When constituted TabbedPage/NavigationPage/ContentPage, didn't move correctly.
 
 ## Default Value changed