Twitter/X news provider > fix cache validity...

[mmathieum]

• cache was 24*2 = 48 hours 🤯

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the cache validity and simplifying API level handling within the Twitter news provider. It removes redundant API version checks and annotations, streamlines cache duration settings, and refines the logic for determining when news data needs to be refreshed. Additionally, minor code style improvements were applied to the generic news provider for better readability.

Highlights

• API Level Compatibility: Removed Build.VERSION.SDK_INT checks and @RequiresApi annotations, simplifying code related to Android API level compatibility in the Twitter news provider.
• Cache Validity Optimization: Adjusted cache validity constants in TwitterNewsProvider to optimize news refresh intervals, specifically reducing the 'in focus' validity from 2 hours to 1 hour.
• News Update Logic Refinement: Refined the logic for determining when to update agency news data, making the cache expiration check more explicit and efficient.
• Code Readability Improvements: Improved code readability in NewsProvider.java by adding final modifiers to local variables.

Changelog

• src/main/java/org/mtransit/android/commons/provider/TwitterNewsProvider.kt
  • Removed android.os.Build and androidx.annotation.RequiresApi imports.
  • Eliminated VALIDITY_DEBUG_FACTOR and set VALIDITY_EXPANSIVE_API_FACTOR to a constant 1L.
  • Decreased NEWS_VALIDITY_IN_FOCUS_IN_MS from 2 hours to 1 hour.
  • Removed API level conditional checks and @RequiresApi annotations from various methods.
  • Simplified the conditional logic for updating agency news data.
• src/main/java/org/mtransit/android/commons/provider/news/NewsProvider.java
  • Added final keyword to local variables for improved immutability and readability.
  • Updated the cache expiration check to use a tooOldNeedLoadingInMs variable for clarity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adjusts cache validity settings for the Twitter/X news provider. Key changes include reducing cache durations, refactoring cache validation logic for improved clarity, and removing API level restrictions to enable the feature on older Android versions. The changes are logical and well-implemented. I have suggested one minor simplification to further improve code clarity by removing a now-redundant constant.