Update dev scripts (#552)

dev-scripts/check-bash

@@ -11,14 +11,15 @@ set -u
 BASH_SCRIPTS=()
 
 while read -r filepath; do
+  # Check shebang for bash.
   if head -n 1 "${filepath}" | grep --quiet --regexp 'bash'; then
       BASH_SCRIPTS+=("${filepath}")
   fi
 done < <(git ls-files)
 
 readonly BASH_SCRIPTS
 
-# Echo commands to stdout.
+# Echo commands before executing them, by default to stderr.
 set -x
 
 shellcheck "${BASH_SCRIPTS[@]}"

dev-scripts/check-go-formatting

@@ -1,11 +1,8 @@
 #!/usr/bin/env bash
 
-# Exit build script on first failure.
+# Exit on first failure.
 set -e
 
-# Echo commands to stdout.
-set -x
-
 # Exit on unset variable.
 set -u
 
@@ -14,4 +11,4 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
 readonly SCRIPT_DIR
 cd "${SCRIPT_DIR}/.."
 
-test -z "$(gofmt -d .)"
+test -z "$(gofmt -s -d .)"

dev-scripts/check-trailing-newline

@@ -2,8 +2,9 @@
 
 # Verify that all text files end in a trailing newline.
 
-# Exit on first failing command.
+# Exit on first failure.
 set -e
+
 # Exit on unset variable.
 set -u
 
@@ -12,7 +13,6 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
 readonly SCRIPT_DIR
 cd "${SCRIPT_DIR}/.."
 
-
 success=0
 
 while read -r line; do

dev-scripts/check-trailing-whitespace

@@ -2,8 +2,9 @@
 
 # Check for trailing whitespace
 
-# Exit on first failing command.
+# Exit on first failure.
 set -e
+
 # Exit on unset variable.
 set -u
 

dev-scripts/enable-git-hooks

@@ -1,11 +1,14 @@
 #!/usr/bin/env bash
 
-# Run this to enable all git hooks for this project.
-
-set -x
+# Exit on first failure.
 set -e
+
+# Exit on unset variable.
 set -u
 
+# Echo commands before executing them, by default to stderr.
+set -x
+
 # Change directory to repository root.
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
 readonly SCRIPT_DIR
@@ -23,4 +26,4 @@ then
   rm -rf .git/hooks
 fi
 
-ln -s -f ../dev-scripts/git-hooks .git/hooks
+ln --symbolic --force ../dev-scripts/git-hooks .git/hooks

dev-scripts/run-go-tests

@@ -7,14 +7,18 @@
 #  --full   Include slower, more exhaustive tests and capture test coverage
 #           results (outputs to .coverage.html).
 
-# Exit build script on first failure.
+# Exit on first failure.
 set -e
 
-# Echo commands to stdout.
+# Echo commands before executing them, by default to stderr.
 set -x
 
+# Fail when piped commands fail.
+set -o pipefail
+
 full_test=""
-go_test_flags=()
+# Without netgo and osusergo, compilation fails under Nix.
+go_test_flags=("-tags=netgo,osusergo,sqlite_json")
 readonly COVERAGE_FILE_RAW=".coverage.out"
 readonly COVERAGE_FILE_HTML=".coverage.html"
 if [[ "$1" = "--full" ]]; then

dev-scripts/update-scripts

@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Exit on first failing command.
+set -e
+
+# Exit on unset variable.
+set -u
+
+# Echo commands before executing them, by default to stderr.
+set -x
+
+# Update dev scripts in a directory to the latest version available in the
+# dev-scripts repo.
+
+readonly TARGET_DEV_SCRIPTS="${PWD}/dev-scripts"
+if [[ ! -d "${TARGET_DEV_SCRIPTS}" ]]; then
+  echo "No dev-scripts directory found"
+  echo "Run this from a project with a dev-scripts directory."
+  exit 1
+fi
+
+cd "$(mktemp --directory)"
+
+git clone https://github.com/mtlynch/dev-scripts .
+readonly GOLDEN_DEV_SCRIPTS="${PWD}/dev-scripts"
+
+for f in "${GOLDEN_DEV_SCRIPTS}/"*; do
+  FILENAME="$(basename "${f}")"
+  TARGET_SCRIPT="${TARGET_DEV_SCRIPTS}/${FILENAME}"
+  if [[ ! -f "${TARGET_SCRIPT}" ]]; then
+    continue
+  fi
+  GOLDEN_SCRIPT="${GOLDEN_DEV_SCRIPTS}/${FILENAME}"
+  cp "${GOLDEN_SCRIPT}" "${TARGET_SCRIPT}"
+  chmod +x "${TARGET_SCRIPT}"
+done