Update on Miri coverage #2438
Open
Update on Miri coverage #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
added a commit
to Skgland/scryer-prolog
that referenced
this pull request
Jul 6, 2024
- removed some unsafe - added some safety comments - add explicit types to transmute calls - reworked UntypedArenaPtr -> TypedArenaPtr conversion might help with mthom#2438, I noticed fewer complains from miri after changing the default impl for `ArenaAllocated::alloc`
Skgland
added a commit
to Skgland/scryer-prolog
that referenced
this pull request
Jul 6, 2024
Skgland
added a commit
to Skgland/scryer-prolog
that referenced
this pull request
Jul 6, 2024
probably relevant to mthom#2438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a lot of the unsafe code in Scryer was improved in #2393, so I did another pass with Miri on the tests that were previously blocked on
arena.rsandstreams.rs(which were improved since then). All tests that were previously blocked by UB instreams.rsare now blocked by UB inarena.rsinstead (with the exception ofpstr_iter_testswhich is now blocked onatom_table.rsUB). All of the tests that are blocked onarena.rsUB are blocked on the transmute in theptr_to_allocated()function, in every case trying to allocate a stream, usually when creating an instance ofMachine.This is good because if this is resolved then all of those tests will go deeper and maybe even pass. I don't know what exactly is the reason for Miri pointing UB here, but it's probably because somewhere in all the transmutes and casts back and forth between
AllocSlabandTypedAllocSlabit's losing provenance information.