-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtool: update to 2.5.2 #4897
base: master
Are you sure you want to change the base?
libtool: update to 2.5.2 #4897
Conversation
Thanks, these patches were all removed because they are not relevant for cygwin? Or any other reason?
the rest looks good to me. |
Actually, I don't know how to refresh it. -specs=*|-fsanitize=*|-fno-sanitize*|-shared-libsan|-static-libsan| \
-ffile-prefix-map=*|-fdebug-prefix-map=*|-fmacro-prefix-map=*|-fprofile-prefix-map=*| \
-fdiagnostics-color*|-frecord-gcc-switches| \
-fuse-ld=*|-static-*|-fcilkplus|-Wa,*|-Werror|-Werror=*) libtool had added most of these flags (except Additionally, I built binutils and gcc several times, they both works properly for me. If this patch really needed, please tell me.
This patch seems fixes nothing.
I revert them back in 7fdd2a9. |
Imho, it is a good thing that libtool is the same in MSYS2 and in the MinGW environments. Is there a good reason to no longer keep the patches in sync between the two? |
it at least used to be the case that the msys2 libtool script was frequently used while generating autoreconf for packages being built from MINGW-packages. |
Oh, yes. Maybe I'm wrong. My removal of these patches causes inconsistent behavior between the two libtool. autoconf always add msys target support, but mingw-w64-libtool broken it without |
Afaict, the 0003-patch hasn't been upstreamed (at least some parts of it haven't). See: IIUC, the current patch names are the ones that are generated by a |
it used to be a case for some times, but was reverted via msys2/MINGW-packages@31cf2ca (see commit message for details) In theory this package could skip mingw specific packages, but you need to rebase them anyway, so it's probably easier to just keep both libtool packages in sync. |
I'm sorry for my late reply. I was too busy that have no time to working on libtool update.
Hi, mmuetzel. Thank you for pointing out my mistake directly, and I apologize for these "smart-ass" changes. I'll revert it back later.
It took me some time to get the drift in Here's a guess as to why the maintainers of libtool didn't added these flags. Please run the following codes in your bash with MSYS2 environment. (I think they noticed this patch, but some parts not upstreamed) libtool --version | head -1
echo "void foo(void) {}" >foo.c
libtool --mode=compile --tag=CC cc -c foo.c -o foo.lo -O3 -ffast-math
libtool --mode=link --tag=CC cc foo.lo -o libfoo.la -O3 -ffast-math -rpath /usr/lib -version-info 0 -no-undefined Here is the output of v2.5.2.
Here is the output of v2.4.7.
As you can see, According to the I've noticed the following patches related to it also applied in Debian's libtool without above flags (you can download 0001-libtool-fix-GCC-linking-with-specs.patch 0020-libtool-fix-GCC-clang-linking-with-fsanitize.patch 0025-libtool-pass-use-ld.patch 0055-pass-flags-unchanged.patch They built the whole Debian system without these flags, so I think they are not necessary. Thanks for your continued attention for this PR. :D |
Just I think "-l" "-whe" represents nothing and nosense, so I removed it manually. |
The omission of See, e.g., this page:
And in the footnote:
To be honest, I don't understand the intricacies involved here. |
Based on my previous PR (#4826).
The propose of this PR is as follows:
PKGBUILD
following mingw-w64-libtoolautoconf -f
to regenerate some files with msys target supportHere is the difference between the original patches and the refreshed ones.
ltmain.sh