[new package] add rio terminal #22012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biswa96
reviewed
Sep 22, 2024
| "${MINGW_PACKAGE_PREFIX}-cc" | ||
| "${MINGW_PACKAGE_PREFIX}-pkgconf" | ||
| "${MINGW_PACKAGE_PREFIX}-cmake" | ||
| "${MINGW_PACKAGE_PREFIX}-freetype" |
There was a problem hiding this comment.
Are you sure fontconfig and freetype dependencies are required in this build? Those are not shown in the runtime libraries list in CI log.
There was a problem hiding this comment.
rust only can be left. cmake is usually used for libz-ng-sys, which is not used for package, freetype and fontconfig are probably used for Linux/macos, I didn't find them all in build logs
ognevny
reviewed
Sep 22, 2024
| build() { | ||
| cd "${_realname}-${pkgver}" | ||
|
|
||
| cargo build --frozen --release --all-features |
There was a problem hiding this comment.
is --all-features required? I see all useful features are already enabled by default upstream
Biswa96
reviewed
Sep 22, 2024
| pkgrel=1 | ||
| pkgdesc="A hardware-accelerated GPU terminal emulator powered by WebGPU (mingw-w64)" | ||
| arch=('any') | ||
| mingw_arch=('mingw64' 'ucrt64' 'clang64') |
There was a problem hiding this comment.
Suggested change
| mingw_arch=('mingw64' 'ucrt64' 'clang64') | |
| mingw_arch=('ucrt64' 'clang64' 'clangarm64') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the LTO issue on upstream!