Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: update to 1.8.1 #20396

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

podsvirov
Copy link
Collaborator

No description provided.

@Biswa96
Copy link
Member

Biswa96 commented Mar 21, 2024

Reverse dependencies need pkgrel bump.

@podsvirov
Copy link
Collaborator Author

Of course you're right. I'll try to do this soon. But I don't mind if someone does it while I'm a little busy with other things.

@lazka lazka marked this pull request as draft March 21, 2024 07:58
@podsvirov
Copy link
Collaborator Author

Reverse dependencies need pkgrel bump.

I've done a little analysis and it seems the world is not ready for this update yet :-).
We need to wait a bit for the dependent packages to support this version.

@ognevny
Copy link
Collaborator

ognevny commented Jun 26, 2024

IMO it's ok to push an update to 1.8.1 and rebuilds for reverse dependencies. Arch already did this

@podsvirov podsvirov changed the title libgit2: update to 1.8.0 libgit2: update to 1.8.1 Jun 27, 2024
@podsvirov
Copy link
Collaborator Author

Updated to 1.8.1.

$ pacboy  -Sii libgit2:u
...
Required By     : mingw-w64-ucrt-x86_64-bat  mingw-w64-ucrt-x86_64-cargo-c  mingw-w64-ucrt-x86_64-cargo-generate  mingw-w64-ucrt-x86_64-delta
                  mingw-w64-ucrt-x86_64-fritzing  mingw-w64-ucrt-x86_64-geany-plugins  mingw-w64-ucrt-x86_64-gitui  mingw-w64-ucrt-x86_64-jj
                  mingw-w64-ucrt-x86_64-kicad  mingw-w64-ucrt-x86_64-ktexteditor-qt5  mingw-w64-ucrt-x86_64-libgit2-glib  mingw-w64-ucrt-x86_64-lsd
                  mingw-w64-ucrt-x86_64-python-pygit2  mingw-w64-ucrt-x86_64-zed
...

Should we rebuild all these packages or something else?

@ognevny
Copy link
Collaborator

ognevny commented Jun 27, 2024

Updated to 1.8.1.

$ pacboy  -Sii libgit2:u
...
Required By     : mingw-w64-ucrt-x86_64-bat  mingw-w64-ucrt-x86_64-cargo-c  mingw-w64-ucrt-x86_64-cargo-generate  mingw-w64-ucrt-x86_64-delta
                  mingw-w64-ucrt-x86_64-fritzing  mingw-w64-ucrt-x86_64-geany-plugins  mingw-w64-ucrt-x86_64-gitui  mingw-w64-ucrt-x86_64-jj
                  mingw-w64-ucrt-x86_64-kicad  mingw-w64-ucrt-x86_64-ktexteditor-qt5  mingw-w64-ucrt-x86_64-libgit2-glib  mingw-w64-ucrt-x86_64-lsd
                  mingw-w64-ucrt-x86_64-python-pygit2  mingw-w64-ucrt-x86_64-zed
...

Should we rebuild all these packages or something else?

look at package-grokker output first. at least don't rebuild zed, as there is a update PR for it: #21254

upd.: for rust packages you need to update git2 crate to 0.19.0

@ognevny
Copy link
Collaborator

ognevny commented Jun 28, 2024

cargo update -p git2 --precise 0.19.0 doesn't work? I think there is no need for a patch

@podsvirov
Copy link
Collaborator Author

cargo update -p git2 --precise 0.19.0 doesn't work? I think there is no need for a patch

    Updating crates.io index
error: failed to select a version for the requirement `git2 = "^0.18"`
candidate versions found which didn't match: 0.19.0

@podsvirov
Copy link
Collaborator Author

Hm, clang64 (but not for others) failed for lsd::

  ==> Validating source files with sha256sums...
      lsd-1.1.2.tar.gz ... Passed
      1021.patch ... FAILED
      0001-lsd-1.1.2-update-git2.patch ... Passed

@ognevny
Copy link
Collaborator

ognevny commented Jun 29, 2024

Hm, clang64 (but not for others) failed for lsd::

  ==> Validating source files with sha256sums...
      lsd-1.1.2.tar.gz ... Passed
      1021.patch ... FAILED
      0001-lsd-1.1.2-update-git2.patch ... Passed

change it to upstream commit: lsd-rs/lsd@575f505

@podsvirov podsvirov force-pushed the libgit2-update branch 2 times, most recently from a2d279b to b074487 Compare June 30, 2024 04:40
@podsvirov podsvirov force-pushed the libgit2-update branch 5 times, most recently from d79e152 to e7e6858 Compare October 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants