Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkada: update to 24.0.0 #19665

Merged
merged 1 commit into from
Jan 7, 2024
Merged

gtkada: update to 24.0.0 #19665

merged 1 commit into from
Jan 7, 2024

Conversation

sad-poet
Copy link
Contributor

@sad-poet sad-poet commented Jan 6, 2024

No description provided.

@Biswa96 Biswa96 merged commit 9791ecd into msys2:master Jan 7, 2024
8 checks passed
@MehdiChinoune
Copy link
Collaborator

There is a collection of adacore packages all of them are at 23.0.0.
I don't know if it's safe to update some to 24.0.0 while the others still at 23.0.0?
Maybe contact Adacore maintainers before.
ArchLinux aur update all of them to same version by checking tags and specified commits.

@Biswa96
Copy link
Member

Biswa96 commented Jan 7, 2024

@Fabien-Chouteau Would you like to provide any info if it is ok to update ada pacakges to version 24?

@MehdiChinoune
Copy link
Collaborator

@sad-poet
Copy link
Contributor Author

sad-poet commented Jan 7, 2024

Hello! I am the author of this pull request and other recent PRs that update some of the AdaCore packages (#19666, #19667, #19668).

My goal is to add a GNAT Studio package and its dependencies to the MSYS2 repository. For that purpose, I have created a large draft branch in my fork, which is now comprised of 7 updated and 25 added packages, all compatible with the version 24. From that branch, I was finally able to build GNAT Studio and its dependencies on my local machine.

What I was trying to do is to bring these changes in small portions, package by package, so that I could more easily pinpoint which PKGBUILDs might have errors and fail the CI build. Do you think it makes sense to create one big pull request instead?

Looking forward to further collaboration.

@MehdiChinoune
Copy link
Collaborator

The question is: Is it safe to update some to 24.0.0 and leave some in 23.0.0 (libadalang and langkit).

@sad-poet
Copy link
Contributor Author

sad-poet commented Jan 7, 2024

https://github.com/AdaCore/langkit/tags
https://github.com/AdaCore/libadalang/tags

Thank you for mentioning this. It's a bit inconvenient that these 2 repositories do not have a published 24.x.x tag, but I think I have found a solution. langkit and libadalang are 2 dependencies of ada-language-server, which luckily for us publishes the list of used dependencies' commits with each release, for example:

 # 24.0.3

libadalang: d65d56bc39c225e07089cb01ead6f81666e4218e
langkit: f658896058a1bdd0993b54577700233563cbf878
libadalang-tools: 2a8f13e469527c9ac57e7d9f1c43e4559bd3ba9c
VSS: fda4c4e6f2cb74346938f62f1ec0c099e015ce82
spawn: 806ae6dd6e353e318de365259acb2708067e7741
gpr: bf7701a359ff700331a1409675f9ffa980091cba
gnatcoll-core: bdb92c2f80546c1b55eb90970f996cff2edb4b58
gnatcoll-bindings: 3bc4980735421be6647edf0b8de1000f84dc4cec
gprbuild: b966cb1dc964e85921b4ee1b81945739fcd02ab0
templates-parser: eb562fa08012e4f41cee45c26e542927f4fc0ae0
markdown: 522ac0682d656f7a8c4a1d0116a8ddd732d2dad9
AdaSAT: f948e2271aec51f9313fa41ff3c00230a483f9e8
gnatdoc: 4af0823d8bf4897539a53140f0341797d2e24396
lal-refactor: 648839905bb1c1182c2fb693642931e5a8c7af2c

I suggest that we use these commit numbers where there is no published 24.x Git tag, because these are the exact versions that are used in the AdaCore CI processes, as far as I can see.

@sad-poet
Copy link
Contributor Author

sad-poet commented Jan 7, 2024

As an alternative to Git tags, all the relevant AdaCore repositories maintain "stable" branches like 24.0 and 24.1.
Documentation for libadalang and its README file both mention (search for the word "branch") that it is safe to build the dependent repositories from the same "stable" branch. I would assume that it is true for all AdaCore repositories, including GNAT Studio.

@MehdiChinoune
Copy link
Collaborator

@Fabien-Chouteau
Copy link
Contributor

Hi @sad-poet and @MehdiChinoune,

You should always take the same major version number for all libraries. For this specific update of GTKAda, there is no problem as there is no dependency on other AdaCore libraries. If you want to build libadalang 24.0.0 on the other hand, you have to use 24.0.0 releases for all the dependencies.

About the ada-language-server 24.0.3 "release", this is a preview and you should take the 24.0.0 tags instead.

@sad-poet
Copy link
Contributor Author

Hello @Fabien-Chouteau, @MehdiChinoune, and @Biswa96,

May I suggest you take a look at the pull request #19761, which provides packages for Ada Language Server and GNAT Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants