chore: migrate eslint to flat config #2212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiSpencer
commented
Jul 20, 2024
Comment on lines
-2
to
+5
| const SOURCE_FRAME = /[\/\\]msw[\/\\]src[\/\\](.+)/ | ||
| const SOURCE_FRAME = /[/\\]msw[/\\]src[/\\](.+)/ | ||
|
|
||
| const BUILD_FRAME = | ||
| /(node_modules)?[\/\\]lib[\/\\](core|browser|node|native|iife)[\/\\]|^[^\/\\]*$/ | ||
| /(node_modules)?[/\\]lib[/\\](core|browser|node|native|iife)[/\\]|^[^/\\]*$/ |
There was a problem hiding this comment.
For this and other regex, eslint warned of unnecessary escape.
| @@ -160,6 +160,7 @@ async function getGraphQLInput(request: Request): Promise<GraphQLInput | null> { | |||
| variables, | |||
| } | |||
| } | |||
| return null | |||
There was a problem hiding this comment.
Missing fallthrough lint warning (with new rules).
Happy to move this to an ignore and then address this separately
kettanaito
reviewed
Sep 28, 2024
| @@ -0,0 +1,59 @@ | |||
| // @ts-check | |||
There was a problem hiding this comment.
Is there any chance the config can be written in TypeScript?
There was a problem hiding this comment.
It can indeed. Although only through an unstable_ flag in eslint. see here
Pull in the unstable flag (and jiti dev dependency) or leave as js?
There was a problem hiding this comment.
Hey @kettanaito, Would you be happy to implement in this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed some suggestions based on recommended lint rules from the newer version of eslint and tseslint, not sure they are all entirely correct!