feat: add basic OR query #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to take a crack at this issue here: #89
I've made a very basic POC that just adds the ability to do an OR query on the first level, haven't made it work recursively yet, only made sure that the type checks pass and the test I created passes.
Just wanted to make sure that @kettanaito was okay with the general direction of this PR, and if you have any improvement or suggestions you have for me, especially about the types, because quite frankly I'm not a Typescript expert, and the code style as well.
Next would probably be making this actually recursive, and then trying to add AND as well.